Skip to content

Fix: Add workaround for commit messages without a colon - #18

Merged
LordAro merged 1 commit into
OpenTTD:mainfrom
PeterN:changelog-missing-colon
Oct 24, 2026
Merged

LordAro merged 1 commit into
OpenTTD:mainfrom
PeterN:changelog-missing-colon

Conversation

@PeterN

@PeterN PeterN commented Oct 24, 2026

Copy link
Copy Markdown
Member

Parsing commit messages breaks if the first line does not contain a colon :. This should never happen, but it can happen by mistake.

This is resolved by testing if a : is present and if not defaulting the commit to a "Change".

Shouldn't exist but can happen by mistake.

@glx22 glx22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, when "squash and merge" with wrong PR title and not properly checking (happened to me sometimes).

@LordAro
LordAro merged commit 331d870 into OpenTTD:main Oct 24, 2026
6 checks passed
@PeterN
PeterN deleted the changelog-missing-colon branch October 24, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants