Repository navigation
Package the OMSimulator XML schemas in libomsimulator - #84
Merged
Merged
Conversation
The Python OMSimulator validates every FMU and SSP against the schemas that CMake installs to usr/lib/<triple>/omc/OMSimulator/schema, but libomsimulator.install only listed OMSimulator/*.py. The schema directory was dropped (dh_missing only lists it), so the packaged OMSimulator failed on every model with an XMLSchemaParseError. Fixes OpenModelica#83 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83.
The Python OMSimulator validates every FMU and SSP against XML schemas that OMSimulator's CMake installs next to its modules, in
usr/lib/<triple>/omc/OMSimulator/schema/{fmi2,fmi3,ssp}.debian/libomsimulator.installonly listedOMSimulator/*.py, so the schema directory never reached a package.dh_missing --list-missingonly reports such files, so nothing failed at build time. The packagedOMSimulatorthen fails on every model:This adds the schema directory to
libomsimulator.install.Testing
I ran
dh_install -plibomsimulatorwith thisdebian/directory against adebian/tmpfilled from a real CMake install of OMSimulator (v3.0.0.post202):libomsimulator.install.xsdfiles in the package (of 25 installed)schema/fmi2,schema/fmi3,schema/ssp)The same OMSimulator with its
schema/directory in place loads and simulates FMI 2.0 FMUs in both co-simulation and model exchange.The full Debian build in CI was not run. It only runs with the
CI/Full Debian Packaginglabel.generated by Claude Code