Repository navigation
Conversation
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
The launcher jar has no log4j on its classpath, so the logger is still looked up through the context classloader, the same way MirthLauncher already does it. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
mgaffigan,
pacmano1 and
ssrowe
October 30, 2026 10:43
Test Results128 files - 2 128 suites - 2 3m 48s ⏱️ +37s Results for commit dd012af. ± Comparison against base commit 4589238. This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mgaffigan
previously approved these changes
Oct 30, 2026
Contributor
|
Let's kill the bridge, too. We don't want to break user scripts unnecessarily, but this one seems like it can be compensated by a plugin - and the scripts have had a decade or two to update. |
Nothing in the engine calls the log4j 1.x API any more, so remove log4j-1.2-api from the distribution. slf4j-log4j12 bound slf4j to the log4j 1.x classes the bridge provided, so replace it with log4j-slf4j-impl. The transformer script now resets its logger through the log4j2 LogManager. The vendored not-going-to-be-commons-ssl jar called log4j 1.x directly and was only kept for SoapUI, which the engine no longer uses. Remove it together with its regression test and the leftover SoapUI log4j config. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
MyBatis 3.1.1 has no log4j2 adapter, and its log4j adapter needs the log4j 1.x classes the bridge used to provide, so the server could not start. commons-logging hands MyBatis logging to the log4j2 API. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the last Java uses of the log4j 1.x API to log4j2:
DefaultDebugUsageControllernow usesLogManager/Loggerlike the other controllers.ExtensionStatusesandExtensionStatusProviderlook uporg.apache.logging.log4j.LogManagerreflectively instead oforg.apache.log4j.Logger.Why
These were the only Java callers of the 1.2 bridge API. The bridge itself stays, because the generated transformer script still exposes
org.apache.log4j.Loggerto user scripts.Reviewer notes
LoggerWrapperusageMirthLauncheralready does../gradlew :server:compileJavaandDebugUsageControllerTest. No automated test covers the extprops path.🤖 Generated with Claude Code