Repository navigation
build(goreleaser): use dockers_v2 for container releases - #147
Merged
Merged
Conversation
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
synackd
approved these changes
Nov 10, 2026
synackd
left a comment
Contributor
There was a problem hiding this comment.
My only concern is feature creep / increased maintenance with the added scripts and action; however, since we are trying to focus on transitioning to metadata-service, I'm willing to mention it here and accept it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a comprehensive overhaul of the release workflow, focusing on improving the reliability, security, and validation of release builds and published images. The changes replace the previous shared workflow with a custom, in-repo workflow that ensures consistent build environments, enforces provenance and SBOM (Software Bill of Materials) attestation, and adds rigorous validation and testing scripts for release artifacts. New scripts and tests have been added to verify that all release images and binaries meet production requirements and that published images are properly attested.
Release workflow improvements:
go-build-release.ymlworkflow with a custom in-repo workflow in.github/workflows/Release.yml, ensuring builds run onubuntu-24.04for compatibility, and introducing explicit steps for Go setup, Docker buildx, cross-compilers, and attestation of binaries and images. The workflow now includes steps to select release or snapshot mode, build and release with GoReleaser, and attest both binaries and images with provenance. [1] [2] [3]Build environment and tooling:
.github/actions/release-setup/action.ymlto standardize the Go toolchain, cross-compilers, and Docker BuildKit setup for consistent release builds across PRs and releases.Validation and verification scripts:
.github/scripts/release_build.py, a Python script that validates release artifacts by checking that binaries and images for bothamd64andarm64architectures are present, that images are properly attested with provenance and SBOMs, and that the OCI index structure meets production requirements..github/scripts/release-image-digests.cjs, a Node.js script to select and verify the digests of published images for each architecture, ensuring only valid, versioned images are attested.Testing for release validation:
.github/scripts/test_release_build.pytests the Python validation of builds, OCI index, and production contract enforcement..github/scripts/release-image-digests.test.cjstests the image digest selection logic, including error handling for missing or invalid digests. [1] [2]Dependency management:
.github/scripts/requirements-release.txtto specify the required Python dependencies (notablyPyYAML) for running the new release validation scripts.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change