Repository navigation
Add themed Kubernetes diagrams and image contribution guidance - #3518
Open
samironsoctopus wants to merge 7 commits into
Open
samironsoctopus wants to merge 7 commits into
samironsoctopus wants to merge 7 commits into
Conversation
Replace the Deploy Container and Load Balancer diagrams with Figma exports in light and dark variants. Images marked theme-light-only or theme-dark-only are hidden by the html[data-theme] attribute, so the swap follows the site's theme toggle as well as the OS setting. SVG figures now fill the content column, and the zoom lightbox no longer caps vector images at their exported width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace both diagrams with revised Figma exports, and update the Deploy Container figure's width and height to the new 480x270 size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add guidance to the README on deciding whether a page needs a screenshot, sizing PNGs and SVGs for the content column, creating clear images, and adding light and dark variants with the theme-light-only and theme-dark-only classes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pull request environment is available at https://stoctodocspr3518.z22.web.core.windows.net/. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
SVG files are markup, not prose, so cspell flags attribute names such as stroke-dasharray. Diagram labels exported from Figma are outlined paths, so there's no text in them to check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…loy/docs into si/update-kubernetes-diagrams
samironsoctopus
requested review from
KMajkrzakOctopus and
enf0rc3
and removed request for
KMajkrzakOctopus
October 19, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces two diagrams on the Kubernetes step pages with light and dark variants that follow the site theme. Also adds contributor guidance on when to use screenshots and how to make images follow the theme.
Themed images
theme-light-onlyandtheme-dark-onlyclasses insrc/styles/main.css. They key offhtml[data-theme], so images follow the site's theme toggle as well as the OS setting.<picture>withprefers-color-schemewould only follow the OS setting, and the zoom lightbox would always show its fallback image.kubernetes-resources.mdwith light and dark SVGs exported from Figma.kubernetes-resources.mdandkubernetes-service.mdwith light and dark SVGs, stored in the sharedpublic/docs/img/kubernetes/steps/folder.deploy-container.svgandloadbalancer.svg, which nothing else referenced.SVG sizing
figurenow fill the content column (figure img[src$='.svg'] { width: 100%; }), because they scale without losing sharpness. This also widenshigh-availability.svgslightly, from 800px to the column width. The other existing SVG figures were already column-width.src/scripts/modules/figures.jsno longer limits vector images to their exported width. PNG and JPG keep the existing limit.Contributor guidance (
README.md)Testing
markdownlint-cli2passes on the changed pages and the README.astro dev:pnpm buildor the Playwright test suite.Follow-up
#16191Fbackground. The README recommends the page colour#111A23.src/styles/main.cssstill says content images sit on a white background. The rule now uses a colour that changes with the theme.🤖 Generated with Claude Code