Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the library from Java 11 to Java 21. Build configuration and CI only —
no source changes were needed, the existing sources compile unchanged.
pom.xml:java.version11 → 21;maven.compiler.source/targetreplacedby
maven.compiler.release, which also rejects references to APIs newer thanthe target
pom.xml: pinnedmaven-compiler-plugininpluginManagement(theversion.compiler.pluginproperty existed but was wired to no plugin, so theversion was floating); JaCoCo 0.8.10 → 0.8.12 for Java 21 bytecode
java-version: 21in the three workflows, anddistribution: adopt→temurinsinceadoptis deprecated and publishes no Java 21 buildsTested
mvn clean installon Temurin 21.0.12 — compiled atrelease 21, 99/99 testsgreen, jar built.
japicmp could not be run locally: it fetched an EU Login HTML page instead of
the baseline jar through the corporate proxy, so the run used
-Djapicmp.skip=true. The API-compatibility check needs to pass in CI here.Note for reviewers
This raises the bytecode level of a published artifact, so every consumer must
be on Java 21 before taking the release — a major-version change under semver.
Jira targets ECL 2.0.0 for that reason.
A stale
origin/java21branch (June 2025) reached the same pom conclusionsindependently; it predates a year of develop and should probably be deleted.
It also bumps
maven-source-pluginto 3.3.1, which this branch does not.Jira: TEDEFO-5287