Skip to content

user: keep usernames out of console format strings #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msimerson merged 1 commit into from
Oct 16, 2026
Merged

user: keep usernames out of console format strings #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/user/credentials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class Credentials {
try {
hashed = await this.hashAuthPbkdf2(passTry, salt, storedIters)
} catch (err) {
console.error(`PBKDF2 failed for user ${username}`, err)
console.error('PBKDF2 failed for user %s', username, err)
return invalid
}

Expand Down
2 changes: 1 addition & 1 deletion lib/user/store/file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class UserRepoFile extends UserBase {
Object.assign(row, upgraded)
})
} catch (err) {
console.warn(`password hash upgrade failed for user ${authTry.username}`, err)
console.warn('password hash upgrade failed for user %s', authTry.username, err)
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/user/store/mysql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class UserRepoMySQL extends UserBase {
const creds = await Credentials.forStorage(authTry.password)
await Mysql.execute(...Mysql.update('nt_user', { nt_user_id: u.id }, creds))
} catch (err) {
console.warn(`password hash upgrade failed for user ${authTry.username}`, err)
console.warn('password hash upgrade failed for user %s', authTry.username, err)
}
}
for (const f of ['password', 'pass_salt']) {
Expand Down
Loading