Repository navigation
Derive the validated OpenAPI catalog through provision-meos.sh - #227
Closed
estebanzimanyi wants to merge 1 commit into
Closed
estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
openapi-validate.yml regenerates the catalog with tools/provision-meos.sh over the MobilityDB checkout, which runs run.py with MDB_SRC_ROOT naming it, so the @InGroup groups that make a function public are attached and the exposable functions are projected. The workflow refuses a document with no path, and a change to provision-meos.sh runs it. Why: IO-B1 of IO-PLAN.md in MobilityDB #2861. run.py reads the groups from MDB_SRC_ROOT, else from ./_mobilitydb; the workflow set neither, so every function read internal and run 41207016338 published a valid document of 0 paths ("Done: 6073 functions (0 stateless-exposable)", "0 paths, 0 schemas"). Measured: over MobilityDB master 1ff2270f7f, run.py over the source headers without MDB_SRC_ROOT states all 6077 functions internal, 0 exposable, and generate_openapi.py projects 0 paths; through provision-meos.sh the catalog states 3606 exposable functions and the document, valid OpenAPI 3.1, 3606 paths and 35 schemas. The check refuses the document of 0 paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openapi-validate.yml regenerates the catalog with tools/provision-meos.sh over the
MobilityDB checkout, which runs run.py with MDB_SRC_ROOT naming it, so the @InGroup groups
that make a function public are attached and the exposable functions are projected. The
workflow refuses a document with no path, and a change to provision-meos.sh runs it.
Why: IO-B1 of IO-PLAN.md in MobilityDB #2861. run.py reads the groups from MDB_SRC_ROOT,
else from ./_mobilitydb; the workflow set neither, so every function read internal and
run 41207016338 published a valid document of 0 paths ("Done: 6073 functions (0
stateless-exposable)", "0 paths, 0 schemas").
Measured: over MobilityDB master 1ff2270f7f, run.py over the source headers without
MDB_SRC_ROOT states all 6077 functions internal, 0 exposable, and generate_openapi.py
projects 0 paths; through provision-meos.sh the catalog states 3606 exposable functions
and the document, valid OpenAPI 3.1, 3606 paths and 35 schemas. The check refuses the
document of 0 paths.