Repository navigation
Fix imported vanilla ore settings on 1.12.2 - #321
Merged
SkyBlade1978 merged 1 commit intoOct 21, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
|
|
SkyBlade1978
merged commit Oct 21, 2026
0d5569c
into
MinecraftModDevelopmentMods:master-1.12.2
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported vanilla ore rules now respect Manage Vanilla Ores. With it off, Minecraft keeps its normal ore placement. With it on, the imported settings apply without a second Minecraft or OreSpawn default pass.
Existing chunks and saved settings are preserved. This bumps the 1.12.2 release to 4.1.2.112021 and updates the migration and player guides.
The checks cover fresh generation, upgrades, reloads, source selection and Base Metals/Mineralogy. The full build, Javadocs, Eclipse and artifact checks pass.