Skip to content

Keep Forge's splash out of virtual-display checks - #518

Merged
SkyBlade1978 merged 1 commit into
MinecraftModDevelopmentMods:master-1.21.1from
SkyBlade1978:master-1.21.1
Oct 25, 2026
Merged

SkyBlade1978 merged 1 commit into
MinecraftModDevelopmentMods:master-1.21.1from
SkyBlade1978:master-1.21.1

Conversation

@SkyBlade1978

Copy link
Copy Markdown
Contributor

The packaged client check got stuck in Forge's early splash window on two MMD runners. The game never reached the Base Metals checks.

This skips that splash only for the two virtual-display client smokes. Minecraft still opens its normal game window and runs the existing world, rendering and inventory checks. Ordinary launches are unchanged.

  • Add an opt-in smoke setting and check both its enabled and disabled paths.
  • Kill a stuck client process 30 seconds after the existing 15-minute limit.
  • Explain the setting in the build notes.

The offline build, unit tests, generated-data check, artifact audit and Eclipse isolation pass locally. The packaged client also passes with the new setting. All three release JARs are byte-identical to the previous local candidate.

There are no gameplay or save-migration changes in this follow-up.

@SkyBlade1978
SkyBlade1978 merged commit c07f6f3 into MinecraftModDevelopmentMods:master-1.21.1 Oct 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant