Repository navigation
Fix world migration checks in Base Metals 1.20.1 - #515
Merged
SkyBlade1978 merged 1 commit intoOct 25, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
Release 3.1.1.120011 with safer old-world detection, current-player preservation and native chunk reading.
SkyBlade1978
merged commit Oct 25, 2026
36db6af
into
MinecraftModDevelopmentMods:master-1.20.1
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base Metals could try to pre-flatten a world that was already using modern block IDs. This patch only starts that conversion when an old source save or the world's migration record confirms it is needed.
It also stops an old
level.dat_oldfrom replacing the current player or turning on legacy terrain protection. Chunk reading uses Minecraft's supported formats, and conversion backups include external chunk files.Genuine upgrades keep their saved registry maps and support reloads and chunks opened later, including nested custom dimensions. Registry IDs, recipes and ore settings are unchanged.
This is 3.1.1.120011 for Minecraft 1.20.1.
The regression tests failed before the fix and pass afterwards. Checks cover Cyano 1.10, MMD 1.10 and 1.12 saves, modern-world controls, stale backups, mixed regions and later-opened chunks. The local build, GameTests, Javadocs, release-JAR audit and Eclipse isolation checks pass.