Repository navigation
Expose live review URLs through private session locks - #35
Merged
Merged
Conversation
rcosteira79
marked this pull request as ready for review
November 2, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An external tool could identify a saved review but could not reopen its live browser page without parsing CLI output. Publish
reviewUrland, for attached sessions,bridgeUrlin<session>.json.lockafter the server starts listening.Preserve the existing
pid, ownershiptoken, andstartedAtfields and all stdout output. URL publication atomically replaces the lock with mode0600, verifies ownership, and serializes with release so a late write cannot recreate a released lock. Normal shutdown removes the fields with the lock; readers ignore dead PIDs and resume replaces stale locks. The usage guide documents this contract for tools such as Herdr.Validation: typecheck, 55 focused session-library/lifecycle tests, and a Chromium test against real CLI sessions. The browser regression discovers the URL from disk, loads the authenticated review, checks the attached bridge, verifies lock permissions and shutdown removal, and crashes/resumes a session to verify stale-lock replacement. It runs in CI's local browser group. No additional URL logging or session-list exposure is introduced.