Repository navigation
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
In some jurisdictions an organisation has two official numbers: the one it is
registered under, and a separate one the tax authority uses. In the Netherlands
the Chamber of Commerce issues both: the KvK number (registration) and the
RSIN (Rechtspersonen en Samenwerkingsverbanden Informatienummer), which the
Belastingdienst uses and which stichtingen and verenigingen need for ANBI status,
gift deductions and tax returns.
Organization (
0f9a3cb8-…402) can hold the first asregistrationNumber, but hasno place for the second. eCommons CORE keeps an RSIN for the communities it
manages, and once a community has a signed Organization record the board's record
becomes the source of its legal details. The RSIN is the one detail with nowhere
to go.
This PR adds one optional field:
taxNumberregistrationNumber, e.g. the Dutch RSIN.Every existing field, the
requiredlist andadditionalProperties: falseareunchanged.
Why a separate field
registrationNumber. The KvK number and the RSIN are different numberswith different uses, and a Dutch organisation needs both on file.
identifiersmap. A named field is what the rest ofOrganization does (
registrationNumber,iban), and readers can rely on itwithout a convention for keys.
taxNumberout. The descriptionsays this, so readers don't expect a duplicate.
Who may change it
Like every field on Organization,
taxNumberbelongs to the signed record:only a director can set or change it (
authorization), so it carries the sameguarantee as
iban. This PR adds nothing to that rule.Issue Number
None.
Type of change
Optional field only: every Organization record valid today stays valid, and
readers that don't know
taxNumbercan ignore it.How the change has been tested
company.jsonparses as JSON and compiles as JSON Schema draft-07 (Ajv 8 +ajv-formats).
taxNumber(a devstack test stichting) stillvalidates.
taxNumber: "123456789"validates.taxNumbergiven as a number instead of a string.Change checklist