Repository navigation
Don't set the geodiff logger callback on Intel macOS, because there it freezes QGIS. - #330
Merged
Merged
Conversation
MarcelGeo
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related MerginMaps/qgis-plugin#956
The plugin fix ^ avoid QGIS crash but makes QGIS to freeze
To hand our Python logger to geodiff, ctypes has to build a small piece of code while the program runs. The official QGIS build for macOS doesn't allow that. On Intel Macs, the library ctypes relies on keeps retrying forever instead of giving up, so QGIS freezes at high CPU. Apple Silicon Macs aren't affected.
The freeze was hidden behind a crash: QGIS used to be killed earlier, while loading geodiff. MerginMaps/qgis-plugin#957 fixes that crash, and then the plugin froze on the first project download or sync.
import ctypes; ctypes.CFUNCTYPE(None)(lambda: None), freezes QGIS the same way, with no Mergin code involved. Reported to QGIS in macOS Intel: creating a ctypes callback freezes QGIS qgis/QGIS#67825On Intel Macs, geodiff messages no longer go to
client-log.txt; geodiff still prints its errors to stderr. The check also covers the command-line client on Intel Macs, where callbacks would work fine.