Repository navigation
fix(research): make AppImage GLES runtime loading portable - #1471
Closed
w3irdrobot wants to merge 1 commit into
Closed
w3irdrobot wants to merge 1 commit into
w3irdrobot wants to merge 1 commit into
Conversation
Contributor
|
Maple Auth development preview: https://c0025939.maple-auth-dev.pages.dev Commit: Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal. |
Contributor
|
Maple development preview: https://8b14d3b6.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
AnthonyRonning
approved these changes
Nov 8, 2026
w3irdrobot
marked this pull request as draft
November 9, 2026 14:33
Contributor
Author
|
Folded into #1487, together with the TLS, schema and GBM fixes. This commit is included as-is, except its path rewrite no longer copies libgbm or libdrm into the bundle. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Research starts on a Linux host without a compatible GLES library, bundled libepoxy fails its normal soname lookup and retries under a build-machine Nix path. The observed failure aborts WebKitWebProcess while the main Maple process continues logging updater activity.
Bundle libglvnd's GL/GLES dispatch libraries, leaving GPU vendor drivers on the host. Reuse the existing string patcher to make libepoxy's fallback relative to its library and replace the absolute libsoup loads in GStreamer's soup and adaptive-demux plugins with sonames. Keep the patcher's Nix interpreter until packaging-time rewrites finish, then sanitize it for distribution.
Extend the existing AppImage verifiers to reject live Nix library constants in
.rodataand missing libepoxy dlopen dependencies. Ignore stale dynamic strings left by patchelf. Add behavioral tests covering real dlopen, stale DT_NEEDED strings, missing dependencies, and patcher lifecycle; document the packaging behavior.Validation:
scripts/ci/desktop-pr.shpassed in.#desktop-linux, withMAPLE_TAURI_FAKE_UPDATER_SIGNING=1andMAPLE_DISABLE_SHARED_CARGO_BUILD_DIR=1.nix flake check --no-update-lock-filepassed, including the new behavioral tests.Maple_3.4.8_amd64.AppImagestarts in Ubuntu 26.10, reaches frontend and updater logs, and survives until the 30-second timeout (124), without the GLES error or SIGABRT.Hardware acceleration is unverified under Xvfb. Existing plugin search directories/patterns, such as V4L and PipeWire, remain outside this literal-library-path fix.
This change stays separate from #1454's glibc-floor work.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.