Repository navigation
MapWinGIS6 – ActiveX Test Host Enhancement Plan - #57
Merged
Merged
Conversation
- Add vector loading, layer management, navigation, and status UI. - Support multi-file loading and drag-and-drop while retaining automated checks. - Keep displayed layer metadata at the host boundary using existing ActiveX properties. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Interactive loading refreshes status before repainting, so Open and drag-and-drop can display the previous frame’s rendering backend and diagnostic instead of the current result.
1 open issue
What changed in this PR
Enhances the WinForms ActiveX test host for manual validation of vector loading, navigation, and rendering while retaining the generated startup fixture.
Changes:
- Adds multi-file selection and drag-and-drop loading.
- Displays layer names, stable IDs, and feature counts derived from aggregate count changes.
- Adds clear, zoom, and directional pan controls, plus expanded status reporting.
Builds and tests were not rerun during this review.
| File | Description |
|---|---|
samples/CSharp/ActiveXTestHost/MainForm.cs |
Adds dataset loading, a layer list, navigation controls, and detailed status reporting. |
Review effort: Balanced
- Correct operation errors, deferred drops, and loaded-layer bookkeeping. - Restore automation coverage and check loading, navigation, clearing, and rendering status. - Document manual controls and first-layer loading limits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the existing WinForms host for manual validation of the ActiveX control.
Adds vector file selection and drag-and-drop, a layer list with stable IDs and feature counts, clear and zoom controls, directional pan buttons, and status reporting. The generated GeoJSON fixture remains loaded at startup, and the automated mode is unchanged. No dependencies were added.
The ActiveX interface exposes aggregate feature count but no per-layer name/count. The host uses source file names and derives each layer's displayed feature count from the aggregate before/after loading.
Validation: