Repository navigation
Conversation
svc_autostart_failed_mount_is_replaced_by_a_new_mount checks that the new
mount of a profile whose autostart mount failed gets the same auto letter
back, which proves the failed record released it. The service picked that
letter from the live GetLogicalDrives() mask, so a drive mounted by another
gate test (dokany.mount, webdav.redirector) between the two picks moved the
second mount to another letter ("P:" != "X:" once in x86-ia32).
Add svc_opts.logical_drives, the drive mask the letter pick and the
target_in_use check read (NULL = GetLogicalDrives). The boot cores of the
tests use the fake backend, which maps no letter, and pass a fixed mask
with only C: in use, so the autostart takes Z: and the replacement must
take Z: again; the test now asserts that letter too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
unit.svcfailed once in atools/ci-local.ps1 -Pipelinerun (x86-ia32) atsvc_autostart_failed_mount_is_replaced_by_a_new_mount:"P:" != "X:". The test checks that a new mount of a profile whose boot autostart failed gets the sameautoletter back — that is what proves the failed record released its letter. But the service picksautoletters from the liveGetLogicalDrives()mask, so a drive mounted meanwhile by another gate test running in parallel (dokany.mount,webdav.redirector) moves the second pick to another letter.Fix
svc_opts.logical_drives: the drive mask read by the letter pick and thetarget_in_usecheck.NULL=GetLogicalDrives(shipping behavior unchanged).test_service.c(fake backend, which maps no letter) pass a fixed mask with onlyC:in use.Z:, and the replacement must takeZ:again; if the failed record still held its letter, the new mount would getY:.Verification
ctest --test-dir build/x86-ia32 -C Release -R "^unit\.svc$" --repeat until-fail:20: 20/20 passed.tools/ci-local.ps1 -Pipeline: all five presets pass (x86 presets skipdokany.mountunder WOW64, as usual).