Repository navigation
feat(stackit): SSO settings for the deploy/stackit module - #320
Merged
Merged
Conversation
sso_issuer, sso_client_id, sso_client_secret and sso_organisation, all four or none (a precondition on the server refuses a partial set). With them, cloud-init writes /etc/frank/sso.env (the FRANK_SSO_* settings, redirect URL https://<domain>/v1/sso/callback) and the client secret to /etc/frank/sso-client-secret (0600, uid 65532), mounted read-only into the container as FRANK_SSO_CLIENT_SECRET_FILE: never an environment variable. Unset, the user data is as before. For test-frank#2 (Okta on stackit.frank.lab271.dev). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy/stackittakes the SSO settings of ADR-020:sso_issuer,sso_client_id,sso_client_secret(sensitive) andsso_organisation, all four or none.FRANK_SSO_CLIENT_SECRET_FILE), never as an environment variable; the redirect URL is built fromdomain.stackit.frank.lab271.dev.Changes
Added
variables.tf: the foursso_*variables, default empty.main.tf: a precondition on the server that refuses a partial set; the values passed to cloud-init.cloud-init.yaml.tftpl, only whensso_issueris set:/etc/frank/sso.envwithFRANK_SSO_ISSUER,_CLIENT_ID,_CLIENT_SECRET_FILE,_REDIRECT_URL(https://<domain>/v1/sso/callback) and_ORGANISATION;/etc/frank/sso-client-secret, 0600, chowned to 65532, written withjsonencodeso any character survives the YAML;/run/secrets/frank-sso-client-secret, plus--env-file /etc/frank/sso.env.Unset, the rendered user data is unchanged apart from one
chownline guarded by[ -f … ].Changelog
sso_issuer,sso_client_id,sso_client_secret,sso_organisation), all four or none; the client secret reaches FRANK as a mounted file (ADR-020, test-frank#2).Testing
tofu fmt -check,tofu validatetofu console); both parse as YAML; a secret with",:and#comes through unchanged🤖 Generated with Claude Code