Repository navigation
Use explicit LEF files without directory scanning - #2516
Closed
jinchuntan wants to merge 1 commit into
Closed
jinchuntan wants to merge 1 commit into
jinchuntan wants to merge 1 commit into
Conversation
Assisted-by: Codex
Collaborator
|
Thanks for the patch, but 1.) Please, no AI generated patches anymore. While it takes you minutes to generate a patch it takes me a lot more time to review and to maintain the solution. That is not fair. |
Author
|
Understood. Apologies for the extra review work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use only the listed LEF files when an explicit list is provided. Keep automatic discovery when no list is given and update the help text.
Tested with 19 LEF/DEF cases in both layout modes and the testcase from #2294.
Fixes #2294.
Developed and tested with Codex.