Repository navigation
Conversation
isHarryh
suggested changes
Oct 31, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
As pointed out in the review by @isHarryh, the previous commit broke the old behavior where split files could start from either 0 or 1. This commit fixes the regression by only breaking the loop when `i > 0` (using `if i:`). If `split0` is not found, the loop will now correctly continue and try to load `split1`, preserving the compatibility introduced in PR K0lb3#94.
isHarryh
suggested changes
Nov 2, 2026
Contributor
There was a problem hiding this comment.
Suggested changes:
def _load_split_file(
self,
basename: str,
open_f: Optional[Callable[[str], BinaryIO]] = None,
) -> bytes:
file: List[bytes] = []
for i in range(0, 1000):
item = f"{basename}.split{i}"
if open_f is not None:
try:
f = open_f(item)
except (FileNotFoundError, KeyError):
if i:
break
continue
with f:
file.append(f.read())
elif self.fs.exists(item):
with self.fs.open(item, "rb") as f:
file.append(f.read()) # type: ignore
elif i:
break
return b"".join(file)| ) | ||
|
|
||
| def _load_split_file(self, basename: str) -> bytes: | ||
| def _load_split_file(self, basename: str, open_f: Callable[[str], BinaryIO] = None) -> bytes: |
Contributor
There was a problem hiding this comment.
Type annotation of open_f should be wrapped with Optional[...].
| if open_f: | ||
| try: | ||
| file.append(open_f(item).read()) | ||
| except: |
Contributor
There was a problem hiding this comment.
This will cause E722 Do not use bare except ruff error.
| else: | ||
| if i: | ||
| break | ||
|
|
Contributor
There was a problem hiding this comment.
This line has trailing spaces
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #397