Repository navigation
Release 0.39.0: #83, #84 and the review's fixes - #85
Merged
Merged
Conversation
describe_keymaps on macOS walks the character block of every selectable keyboard through UCKeyTranslate, the counterpart of the Windows ToUnicodeEx walk, so a variant whose keys differ from the bundled table (Apple's Arabic against Arabic 101) is corrected on the keys the user has. The current keyboard comes first, as the DB keeps the first of a language. Lam-alef keys fold to their presentation form; tatweel is left out so `_` never reads as a letter.
HunspellSource gains Extras: prefixes attached to every form, respellings for a key that types one code point where the dictionary spells two, and forms dropped last. Every existing source uses NO_EXTRAS. encoding_of_aff now finds a tab-separated SET past the head of the file, and a stems-only dictionary no longer parses affix rules it never uses.
ar.toml read off macOS ArabicPC, a 2.5 M-form Ayaspell wordlist (stems, plus article forms and the B-key lam-alef spelling), a stop list checked against en-US, Arabic's long vowels for plausibility, and presentation forms counted as Arabic script. Mapped on macOS (all Apple Arabic variants), Linux (ara) and in the MSI.
Arabic and Hebrew leave short vowels unwritten, so a correctly typed word with no long vowel (بسرعه) scored 0.0 as one consonant cluster while its en-US rendering (fsnui) scored 0.75, and plausibility switched it away. Text wholly in the current layout's abjad is now kept by plausibility; leaving it takes a dictionary hit. Found in daily use on macOS.
The chime lived only in the word paths of the force-switch hotkey: `convert_selection` pasted the converted text back in silence, so a press that worked looked like one that did nothing. It now plays `SoundEvent::Correct` on success, gated on `general.sound_on_correct` like every other path, and stays silent when nothing was converted.
Follows the merges of #83 and #84. Live in the guest, `table` typed on the Arabic layout came back `فtable`: `B` puts two code points on screen, on Linux too because libX11's Compose table expands xkb's U+FEFB, and every erase counted one per key. All erase sites now go through `extra_backspaces`, a selection is pasted as the pair and reads back as its one key. - ar.toml follows xkb `ara`: ASCII digits, three punctuation keys. - Windows: every `ar-*` locale is `ar`, lam-alef is folded rather than cut to `ل`, and `switch_to` picks the keyboard the table came from. - Hyprland and sway: names for the nine bundled languages they missed. - U+FEFF is no longer Arabic script; xtask's doc comment back on its const; the chime test requires exactly one chime.
… lam-alef Before #83 shape alone turned 19 % of running Hebrew into Latin; the veto stopped that and with it every out-of-dictionary English word typed on an Arabic or Hebrew keyboard. A word in neither dictionary now moves when another layout's FST follows at least 0.34 more of its letters than its own does, clitics stripped. Through the real detectors on Wikipedia text: 0 damaged of 90,086 Arabic and 74,071 Hebrew words, about 40 % of 3,647 out-of-dictionary English words back. A lam-alef key pressed during a correction now costs its second Backspace too, under the layout in effect when it landed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer branch for 0.39.0, opened to run CI on Windows and macOS before it reaches main. Carries the merges of #83 and #84 with their authors' commits intact, plus the fixes from review. Not to be squashed.