Skip to content

Build and test conda packages and wheels - #400

Open
jharlow-intel wants to merge 2 commits into
masterfrom
ci/intel-python-ci
Open

jharlow-intel wants to merge 2 commits into
masterfrom
ci/intel-python-ci

Conversation

@jharlow-intel

@jharlow-intel jharlow-intel commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Adds ci/ and .github/workflows/intel-ci.yml, which build the conda packages for Linux, Windows and Intel macOS and the wheels for Linux and Windows, on every declared Python, and test each in a clean environment.

  • conda-recipe/ is now the only recipe: the conda-forge one that was conda-recipe-cf/. The Intel-channel recipe and conda-package.yml are removed; conda-package-cf.yml builds conda-recipe/ and keeps its check names.
  • The conda packages build Python 3.10 to 3.15 plus 3.14t, from the python: list in conda_build_config.yaml, which also sets numpy: '2', as conda-build otherwise falls back to NumPy 1.26. The wheels follow the pyproject.toml classifiers: 3.10 to 3.15 plus 3.14t and 3.15t.
  • Wheels build with cibuildwheel, with MSVC on Windows, leave MKL out and require mkl >=2026.2,<2027 through [tool.gh-ci] wheel-requires, which ci/build.py adds to each wheel.
  • meson.build adds Library to CMake's search path on Windows, where mkl-devel puts its CMake config.
  • ci/test.py runs pytest --pyargs mkl_fft on the installed package. The SciPy interface tests skip without SciPy or mkl-service, as on the 3.15 wheels, which get no mkl-service from PyPI yet.
  • ci/benchmark.py runs the asv suite in benchmarks/ against the installed package: one quick sample of each benchmark on a pull request, a full measurement on a tag.
  • The Agent guidance job, ci/guidance.py, fails a pull request that adds a broken link, path, script or identifier claim to an agent guidance file it changes. dokimi is installed with the hashes in ci/guidance-requirements.txt.

Miniforge is pinned to 26.7.2-0, as 26.9.4-0 makes setup-miniconda's conda init fail on Windows runners.

Overlap with #398. It changes conda-recipe-cf/, which this moves to conda-recipe/, so whichever lands second needs a rebase.

Validation: run 42099107198 built and tested the conda packages for 3.10 and 3.15 on Linux, Windows and macOS, and the wheels for 3.10 and 3.15 on Linux and Windows; all 22 jobs passed. Not run yet: the full matrix, which only master and tags build.

@jharlow-intel
jharlow-intel marked this pull request as ready for review October 23, 2026 20:42
Copilot AI balanced review requested due to automatic review settings October 23, 2026 20:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Full-version builds and the external Jenkins handoff remain unverified and need maintainer validation.

1 open issue
What changed in this PR

Adds GitHub Actions build and test support for mkl_fft’s conda-forge packages, preparing the repository for Intel Python CI’s future Jenkins integration.

Changes:

  • Derives Linux and Windows build matrices from recipe Python variants, limiting pull requests to the two newest regular versions.
  • Adds package-building and isolated testing scripts, with pytest JUnit reporting.
  • Configures artifact naming, pins Miniforge, and documents the CI integration.
File Description
conda-recipe-cf/​conda_build_config.yaml Declares Python variants and NumPy 2.
conda-recipe-cf/​AGENTS.md Documents the recipe’s matrix role.
ci/​test.py Tests the installed package and writes JUnit results.
ci/​README.md Explains CI operation and local usage.
ci/​matrix.py Derives platform and Python build matrices.
ci/​hooks.py Installs artifacts into isolated test environments.
ci/​config.yml Defines workflow, artifact names, and test requirements.
ci/​build.py Builds and collects packages for a selected Python version.
AGENTS.md Adds the Intel Python CI directory reference.
.github/​workflows/​intel-ci.yml Orchestrates matrix generation, builds, and package tests.
.github/​AGENTS.md Documents the workflow and its matrix source.

Review effort: Balanced

Comment thread ci/matrix.py Resolved

@vchamarthi vchamarthi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scripts look good and match the other repos, and the 22 jobs are green.

The PR description is out of date though. It says the workflow builds conda-recipe-cf (it's deleted now, and conda-recipe/ is replaced by the cf recipe), Linux and Windows only (macOS and wheels are built too), and that Jenkins isn't on for mkl_fft (it's enabled in config/gh-ci.json, dry run). The test counts in it are old as well, the head run shows 2793 and 2787.

It also doesn't say conda-package.yml is deleted. That workflow was the only one building and testing against the Intel channel (software.repos.intel.com/python/conda), which is what the shipped Intel package links against, and nothing replaces it. Rest is inline.


def require_scipy_fft():
"""Skips the test unless mkl_fft has its SciPy interface."""
if scipy_fft is None:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When import mkl fails, the scipy-interface tests now skip instead of failing. So a conda cell where mkl-service is required in ci/config.yml but imports badly still goes green with about 240 fewer tests. You can already see it in the 3.15 wheel cells: 2551 passed and 54 skipped, against 2793 and 2 on Linux. Could ci/test.py check that the scipy interface loaded when mkl-service is in the requirements? Same pattern in test_basic.py and test_multithreading.py.

try:
import mkl_fft.interfaces.scipy_fft as fft
except ImportError:
pytest.skip("This test file needs mkl-service", allow_module_level=True)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in test_interfaces.py: this skip hides a broken mkl-service import.

import mkl_fft.interfaces.scipy_fft as fft
except ImportError:
pytest.skip("This test file needs scipy", allow_module_level=True)
pytest.skip(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same again.

Comment thread conda-recipe/meta.yaml
- python
- {{ pin_compatible('mkl') }}
- numpy >=1.26.4
- numpy

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run requirement goes from numpy >=1.26.4 to a bare numpy, with ignore_run_exports: numpy. conda can now pair this with a numpy 1.x older than the numpy>=1.26.4 in pyproject.toml. Could we use numpy's run_exports instead of ignoring them?


test:
name: Test ${{ matrix.name }} Python ${{ matrix.python }}
needs: [matrix, build]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any build leg fails, macOS included, all the test legs are skipped and the run fails. Jenkins needs a green run, so a macOS-only failure would block a tag release even though Jenkins ignores macOS. Intended? Same on test-wheel at line 175.

# macOS runs on Intel runners, as MKL has no Apple silicon build; Jenkins ignores it.
build:
name: ${{ matrix.name }} Python ${{ matrix.python }}
needs: matrix

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda-package-cf.yml and this workflow now both build conda-recipe on every PR, so the runner load is doubled.

Comment thread ci/test.py Outdated
"""
Intel Python CI (gh-ci) test for mkl_fft.

GitHub Actions, through ci/hooks.py, and Intel's Jenkins both run this with one

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only talks about a conda package, but it tests the wheels too.

@jharlow-intel jharlow-intel changed the title Build and test conda-recipe-cf for Intel Python CI Build and test conda packages and wheels Nov 5, 2026
Adds a ci/ directory and .github/workflows/intel-ci.yml. The workflow builds
conda-recipe/ with conda-build and the wheels with cibuildwheel, for every
platform and Python version the recipe and pyproject.toml declare, and tests
each package in a clean environment with ci/test.py.

conda-recipe/ is now the only recipe, the conda-forge one that was
conda-recipe-cf/; the Intel-channel recipe and conda-package.yml, which copied
wheels out through WHEELS_OUTPUT_FOLDER, are removed. conda-package-cf.yml
reports the same check names, so the required checks still run.
conda_build_config.yaml now lists the Python versions, and numpy: '2', as
conda-build otherwise defaults to 1.26.

The wheels' run-time requirement on mkl comes from [tool.gh-ci] wheel-requires
in pyproject.toml, which ci/build.py adds to each wheel: in [project] it would
fail the recipe's pip check, as conda-forge's mkl has no pip metadata.

The Agent guidance job, ci/guidance.py, fails a pull request that adds a
broken link, path, script or identifier claim to an agent guidance file it
changes. Claims that already fail, and untouched files, never fail it. dokimi
is installed with the hashes in ci/guidance-requirements.txt.

The wheels build against mkl-devel >=2026.2,<2027, the range they require
at run time, and the Linux wheels are tagged manylinux_2_28 only, like the
mkl wheel. ci/build.py keeps only the $ORIGIN entries of each ELF file's
RPATH and RUNPATH in a wheel, as meson-python keeps the isolated build
env's absolute lib directory, and refuses a file that would be left with
none. ci/hooks.py tests each wheel in a venv made from conda-forge's
Python, as pip users install it. Every python: entry in
conda_build_config.yaml names its ABI, which ci/matrix.py requires, and
every push and tag run gets a concurrency group of its own.
conda-build reads x86 as any x86 CPU and has no osx64 selector, while
rattler-build has x86 for 32-bit only and osx64 for Intel macOS, so
ci/matrix.py now gives conda-build its own values for both and refuses a
conda-build skip that uses osx64.

ci/build.py keeps a search path entry only when it is $ORIGIN or a
directory under it, names RPATH and RUNPATH entries apart, and rewrites
the wheels in scratch, so a refused wheel never reaches --output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants