Repository navigation
Conversation
prk-Jr
marked this pull request as ready for review
November 17, 2026 05:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/health) and application-initialization readiness (/ready) probes, so monitoring can distinguish a running handler from a usable application.503responses while enabling application-wide warn/error logging to the Worker console and Spin stderr, including startup diagnostics; keep probes independent of application authentication, cookies, and configured response headers.Compatibility: GET/HEAD
/readybecomes reserved everywhere, and Cloudflare gains local GET/HEAD/health. Move traffic-admission checks to/ready; Axum/healthnow remains live after caught startup failures. Fastly/Axum/Cloudflare startup statuses become503. Readiness does not poll runtime dependencies; ordinary errors after successful startup retain their existing mapping.Changes
.github/workflows/health-startup-contract.ymlAGENTS.md.tool-versionsCHANGELOG.mdcrates/trusted-server-adapter-axum/README.mdcrates/trusted-server-adapter-axum/src/app.rscrates/trusted-server-adapter-cloudflare/README.mdcrates/trusted-server-adapter-cloudflare/src/app.rscrates/trusted-server-adapter-cloudflare/src/lib.rscrates/trusted-server-adapter-fastly/src/app.rscrates/trusted-server-adapter-fastly/src/main.rscrates/trusted-server-adapter-fastly/src/sandbox.rscrates/trusted-server-adapter-spin/README.mdcrates/trusted-server-adapter-spin/src/app.rscrates/trusted-server-adapter-spin/src/lib.rscrates/trusted-server-cli/src/commands/dev/sandbox_probe.rscrates/trusted-server-core/src/health.rscrates/trusted-server-core/src/lib.rscrates/trusted-server-integration-tests/browser/helpers/infra.tscrates/trusted-server-integration-tests/tests/common/trace_boundary.rscrates/trusted-server-integration-tests/tests/environments/axum.rscrates/trusted-server-integration-tests/tests/environments/cloudflare.rscrates/trusted-server-integration-tests/tests/environments/fastly.rscrates/trusted-server-integration-tests/tests/environments/mod.rscrates/trusted-server-integration-tests/tests/html_eof_runtime.rscrates/trusted-server-integration-tests/tests/parity.rsdocs/guide/api-reference.mddocs/guide/axum-dev.mddocs/guide/cloudflare.mddocs/guide/fastly.mddocs/guide/integrations-overview.mddocs/guide/spin.mddocs/superpowers/plans/2026-11-16-1142-health-startup-contract.mddocs/superpowers/specs/2026-11-16-1142-health-startup-contract-design.mdscripts/README.mdscripts/smoke-axum.shscripts/smoke-cloudflare.shscripts/smoke-common.shscripts/smoke-fastly.shscripts/smoke-spin.shCloses
Closes #1142
Spec
Spec: Health and startup-failure contract, including two review rounds.
Implementation and verification: Plan.
Test plan
cargo test-fastly && cargo test-axumcargo test-fastly-reuse && cargo test-cloudflare && cargo test-spinAGENTS.mdcargo fmt --all -- --checkfastly compute servesmoke with Fastly 16.0.0 / Viceroy 0.21.0test-utils; exact GET and raw-wire HEAD, auth/header controls, diagnostic assertions, and publisher sentinel/rewrite controlsLocal baseline checks passed with Rust 1.98.1 and Node 24.20.0. The review correction in
1a801939eadditionally passed fresh Fastly tests in both modes, target-matched Clippy, real deadline fixtures, Rust/Markdown/docs formatting, README contract-link checks, and added-line domain lint. All 35 hosted checks passed on the prior headdba90aa; hosted results for the updated head are separate. Existing ignored tests are not counted as passing runtime smokes.Checklist
unwrap()in production codelogmacros for production diagnostics