Repository navigation
Conversation
proxy.certificate_check only relaxed TLS for the origin wording-wise, but EdgeZero verifies every outbound HTTPS request regardless. Update the error, warning, settings docs, guides and example config to say so, and test that pull sync sends the same request and stores the partner ID whether the check is on or off. Closes #1556
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy.certificate_check = falseno longer relaxes anything, but the error, warning, settings doc comment, guides and example config still said it relaxed the origin.Changes
crates/trusted-server-core/src/ec/pull_sync.rsdispatch_pull_sync_ignores_relaxed_certificate_checkand apull_oncehelpercrates/trusted-server-core/src/config.rscertificate_checkerror and warningcrates/trusted-server-core/src/settings.rscertificate_checkdoc commentdocs/guide/configuration.md,docs/guide/edgezero.md,docs/guide/error-reference.mdtrusted-server.example.tomldocs/superpowers/specs/2026-11-16-identity-backend-certificate-checks-design.mddocs/superpowers/plans/2026-11-16-identity-backend-certificate-checks.mdCloses
Closes #1556
Spec
Not a feature. The design notes are in
docs/superpowers/specs/2026-11-16-identity-backend-certificate-checks-design.md.Test plan
cargo test-fastly: left to CI. The local Viceroy is older than the pinned 0.21.0cargo test-axum,cargo test-cloudflare,cargo test-spincargo clippy-fastly && cargo clippy-axum && cargo clippy-cloudflare && cargo clippy-cloudflare-wasm && cargo clippy-spin-native && cargo clippy-spin-wasmcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcertificate_checkconfig tests pass natively. A mutation check broke the test both ways: making the relaxed setting change the URL, and adding a header.ts dev lint domains --changed-vs origin/mainis clean.Checklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)