Repository navigation
Conversation
Require explicit HTTPS origin and path grants plus current consent before disclosing canonical EC identity. Reevaluate every redirect and coordinate event cache bypass with terminal response privacy. Add shared CLI diagnostics, adapter and real-network coverage, operator migration guidance, and the reviewed design and implementation plan.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts config proxy explain <URL> --json; preserve specialized integration/publisher asset fetching and verify actual CLI-to-Axum resource transport.Changes
.github/workflows/test.ymlcrates/trusted-server-adapter-axum/src/app.rscrates/trusted-server-adapter-axum/src/middleware.rscrates/trusted-server-adapter-cloudflare/src/app.rscrates/trusted-server-adapter-cloudflare/src/middleware.rscrates/trusted-server-adapter-fastly/src/app.rscrates/trusted-server-adapter-fastly/src/main.rscrates/trusted-server-adapter-fastly/src/middleware.rscrates/trusted-server-adapter-fastly/src/proxy_policy_runtime.rscrates/trusted-server-adapter-fastly/tests/proxy-policy-origin.mjscrates/trusted-server-adapter-fastly/tests/proxy-policy-origin.test.mjscrates/trusted-server-adapter-spin/src/app.rscrates/trusted-server-adapter-spin/src/middleware.rscrates/trusted-server-cli/src/commands/config/mod.rscrates/trusted-server-cli/src/commands/config/proxy.rscrates/trusted-server-cli/src/run.rscrates/trusted-server-cli/tests/config_env_overlay.rscrates/trusted-server-cli/tests/config_proxy.rscrates/trusted-server-cli/tests/proxy_trusted_server.rscrates/trusted-server-core/src/config.rscrates/trusted-server-core/src/consent/mod.rscrates/trusted-server-core/src/integrations/google_tag_manager.rscrates/trusted-server-core/src/integrations/gpt.rscrates/trusted-server-core/src/integrations/js_asset_proxy.rscrates/trusted-server-core/src/integrations/testlight.rscrates/trusted-server-core/src/lib.rscrates/trusted-server-core/src/proxy.rscrates/trusted-server-core/src/proxy_policy.rscrates/trusted-server-core/src/proxy_query.rscrates/trusted-server-core/src/response_privacy.rscrates/trusted-server-core/src/settings.rscrates/trusted-server-integration-tests/README.mdcrates/trusted-server-integration-tests/tests/parity.rsdocs/guide/configuration.mddocs/guide/first-party-proxy.mddocs/superpowers/plans/2026-11-16-1233-proxy-disclosure-policy.mddocs/superpowers/specs/2026-11-16-1233-proxy-disclosure-policy-design.mdscripts/README.mdtrusted-server.example.tomlCloses
Closes #1233
Spec
Proxy disclosure and cache policy, including two independent spec review rounds.
Implementation plan and A1–A22 traceability.
Test plan
All checked results below are local. Hosted CI is separate.
cargo test-fastly && cargo test-axum; alsocargo test-fastly-reuse,cargo test-cloudflare, andcargo test-spincargo clippy-fastly && cargo clippy-axum; also Cloudflare native/WASM, Spin native/WASM, CLI and codegen lint aliasescargo fmt --all -- --checkcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serveConfiguration hardening and compatibility
Invalid recipient origins, paths, IDs, duplicate selectors and non-roundtripping paths return configuration errors during typed validation/runtime preparation; every adapter prepares settings before routing. No panic-based recipient compilation is used. Regression coverage includes
proxy_identity_policy_rejects_invalid_runtime_configuration,identity_policy_rejects_invalid_origins,identity_policy_rejects_invalid_paths_and_rule_ids,identity_policy_rejects_duplicate_ids_and_normalized_selectors, andproxy_policy_rejects_selectors_changed_by_url_serialization.Deploy the new binary before publishing a nonempty
proxy.identity_endpointsconfiguration: older strict readers reject the new field. Empty defaults remain omitted. Existing signatures are still validated before query transformation, and removing a rule revokes future disclosure without re-signing URLs. Creative requests deliberately use a fixed user agent and restricted forwarded headers; unfollowed redirects carryingLocationreturn 502. Integration-owned identity payloads and click behavior remain outside this policy.Draft / release qualification
Keep this PR in draft while CI and the documented staging experiments remain unqualified. The local HTTP Viceroy fixture proves destination URL behavior, stripping and redirect exhaustion; it does not prove HTTPS recipient delivery or readthrough cache reuse. Positive HTTPS policy/cache-intent assertions use injected transports through real routes. A controlled deployed origin with counters and reader-distinct responses is still required before claiming production cache/HTTPS qualification. No deployment has been performed.
Checklist
unwrap()in production codelogmacros rather thanprintln!