Repository navigation
Conversation
Address review thread 4491180380. Verify coverage-generated applicability through release validation without approving pending scope.
Address review thread 4491174084. Service ready SDK work without a host wait, record each terminal pipeline turn before further provider I/O, and preserve original deadlines and cached results. Replace closed-port timing assumptions with deterministic readiness and late-collection proofs.
Address review thread 4491175086. Identify removed Fastly environment helpers, document baked hook replacements and adapter-owned delivery, and match the current tool pins.
Address review thread 4491175244. Reuse the paired absolute timer so fractional-millisecond and early wakes cannot become early 408s. Preserve timer failures and verify pending-source release.
Address review thread 4491174465. Sweep every pending pipeline once at cutoff, retain earlier own-deadline results, and release the timer and exchange collection before terminal publication. Verify raw events and the full positional collection contract.
Address review thread 4491176481. Remove the obsolete eager-dispatch dependency while leaving consumer parity and exact-candidate qualification open.
Address review thread 4491175714. Keep zero-read caller overflows retryable, ignore mutated framing headers, and invalidate only the caller length hint after stream mapping. Preserve protected raw caps, deadlines and sticky failures.
Address review thread 4491176612. Retain explicit Rust 1.95 allocation-audit provenance rather than claiming an unperformed 1.98 audit, match the Docker builder pin, and document shared Arc<App> ownership.
Address review thread 4491176729. Include wire authority, connect settings and B31 identity, identify the replaced historical model, and warn against untrusted destination selection.
Address review thread 4491176874. Describe adapter-owned delivery, initialize before request acquisition, fix response types and registry counts, and provide a complete context handler.
Address review threads 4491177045 and 4491179663 atomically. Correct portable declarations and authority caveats, document the default timeout budget, and reject stale delivery wording and incomplete limit tables.
Address review thread 4491177206. Publish the informational host-certified-empty behavior row, preserve the unverified Workers leg and Spin CL=0 exception, and describe current settlement and 408 precedence without promoting raw ingress guarantees.
Address review thread 4491177323. Add Original, Begin, nonblocking check and arrival-recording matrix rows with explicit non-declarable status and Fastly cooperative-progress caveats.
Address review thread 4491177465. State the twice-budget risk, original-entry measurement anchors, expired-preparation exclusion and original post-head deadline without promising a finite host-call horizon.
Address review thread 4491177586. Remove active dispatch-slack claims, name header/body timeout provenance and the measured tolerance, and retain all three synchronous preparation exceptions plus the separate optimizer limitation.
Address review thread 4491179963. Do not execute inherited toolchain Cargo metadata through Bash. Reuse one command factory, retain sentinel and runtime settings, and cover SDK and async-build command construction.
Address review thread 4491178015. Scope echo_stdout to Fastly, document the fallible configure macro argument, and distinguish the config_out_of_date wire kind from Rust variants.
Address review thread 4491177715. Document both stock-runtime limitations, append the already-approved local runtime clarification, and refresh only complete-document identities. Preserve all 255 criterion records, environment legs, strict parity requirements and hosted gates.
Address review thread 4491177865. State per-target observation opportunities, non-yielding CPU delay, no backdating and the earlier own-deadline exception.
Address review thread 4491178161. Include the full audited worker requirement, the scaffold Spin pin, and the actual repository boundary of the action toolchain check.
Address review thread 4491178345. Import response types from their actual modules, identify the application-owned schema, and remove obsolete body/request accessor documentation.
Address review thread 4491178492. Router state wins on every target, followed by Fastly preparation and the adapter default, while manual missing-client behavior stays explicit.
…ck celld The celld providers depended on a scoped listener compiled into a modified celld. Stock celld only exposes storage to Worker code deployed into it, so EdgeZero now ships that code: services/celld-store, a Worker plus one SQLite Durable Object per namespace, deployed with `celld deploy` onto the official release. - Each mutation applies in one SQLite transaction and records its client mutation ID. Stock celld resends a buffered Durable Object call after a pooled peer tunnel fails even when the owner already ran it; the ledger answers that resend with the first outcome. An apply-before window keeps a call held through cell recovery from applying long after the client gave up. - Responses carry a new protocol header and a store instance ID, so forked servers and reset stores fail instead of answering. - Mutations are POST /put and /delete with a fresh 128-bit ID; the client still never resends. - Remove the celld config provider and the fork-only v1 record API. - Replace the modified-celld runner and namespace isolation script with a generated-consumer proof against official celld behind a TLS proxy, and a two-node fleet proof that reproduces the resend and an owner takeover.
… tokens Review follow-ups for the store service: - A 404 counts as an absent key only when the store instance header is present. A routing 404, such as from a proxy that rewrote the path, is now malformed instead of silently reporting existing keys missing. - The Worker accepts any ASCII graphic token, including commas, and still rejects repeated Authorization headers by grammar. - The Kubernetes deploy recipe maps index.js back under src/, because ConfigMap keys cannot contain "/". - The spec no longer claims to detect a rollback to an older snapshot of the same store.
…e/stock-celld-geo-439
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc/identityis the integration branch for server-side identity on every adapter (Platform capabilities for server-side identity on every adapter #468). It carries the ready PRs that Trusted Server's Fastly and Axum MVP needs, joined by history-preserving merges, so Trusted Server can pin one revision and CI can test the combined stack.Included
On main
e11ea308. Heads are current atf84ffbbb; earlier heads stay in the history.ea2549fbc5c6b8e0ce94fe06e37e0df2d3188b1a164995311d89fb4ee9459356c02ee54961fd14d7Moved since
f84ffbbbNone.
#463 closed on 2026-11-13; #422 carries its conditional celld record operations, which this branch already has.
How #275's next review repairs came in (2026-11-17)
#275 moved from
b65e7144toea2549fbby adding 16 fix and docs commits (Fastly response handles and progress wakers, retained outbound failures, body checkpoints, harness supervision, CLI target pinning). #422 had added a stock-celld store service (dd1b8907,15bdeef6), which #439 merged incf291a1e. Each stack PR then merged the PR below it, bottom-up, with no conflicts, and this branch took #439's headc02ee549as a plain merge,f84ffbbb.How #275's review repairs came in (2026-11-16)
#275 moved from
e9ffaa8ftob65e7144by adding four commits:4cbabfee: Fastly logging validation and setup failures (Fastly custom runners send no response when the managed logger fails to install #505, Reject Fastly logging endpoint names the logger cannot install when the manifest loads #506).fe32185f: terminal errors and response policies.c7e3ac97: assembly-failure attestation tests.b65e7144: compile-time logging config for hand-written hooks (Compile-timelogging_forfor applications with a hand-writtenHooksimpl #504).Each stack PR merged the PR below it again, bottom-up, in a merge commit titled
Merge PR #<lower> into PR #<N> for outbound compatibility stack. Only #409 conflicted. Its merge resolves the import block of edgezero-core'sapp.rsby keeping both imports: #409'sRouteErrorKindand #275'sRequiredErrorResponseHeaders. This branch then took #439's headc1cec8e7as a plain merge,3d92ee38, with no conflicts.How #275's rewrite came in
#275's head was rewritten at
e9ffaa8f. The stack's conflicts were not resolved here. Instead, each stack PR merged the PR below it, bottom-up, and resolved its own conflicts in its own merge commit, titledMerge PR #<lower> into PR #<N> for outbound compatibility stack. Rungit show --remerge-diffon a PR's merge to see exactly what its resolution changed. This branch then takes #439's head in a single merge.cf8003f1expect, and its byte-bound assertion under #275's record caps03d192fdb3187e1brun_localandrun_ownedstructure, which now owns #275'sAxumOutboundExecutor77fa6772forwarded_content_lengthandingress_buffer;with_transporttakes the executor and the JSON limite1350bb2from_app_with_native_client_factorytakes the executor; dispatch keeps #409'sinto_partsand inserts the executorbd6cb7abf1d85581302697e8with_native_transporttakes the executor; both theexecutorandgeofieldsEdit in this branch's own merge
87174160merged #439's head with two edits where #469 meets #275, andgit show --remerge-diff 87174160shows both. One is still this branch's own:request.rs: #469'singress_ja4_is_not_exposed_even_with_ja4_headerstest gets an executor handleinto_core_request, and the test does not compile without one. #469 targets main, where the function still takes one argument, so the edit cannot live in #469 until it rebases onto #275The other removed
EdgeZeroAxumServicefrom the Axum guide, because #275'scheck_outbound_legacy_api.shrejects the name. That edit now comes from #469 itself (52f4a09f, the suggestion in its review), merged in10166628with no file change. It was the only red check here before.Open points for the owning PRs
request.rsedit aboveWouldBlock(#503)Not included
87174160, but it has not been built here. Next to addNext on this branch
Each ticket's PR is merged here once it is ready. #482 is the only one with a PR so far.
Refs #488. Part of #468. Planned in IABTechLab/trusted-server#1559.
Test plan
3d92ee38through history-preserving merges10166628has the same tree as8717416087174160check_outbound_legacy_api.shandcheck_outbound_docs_contract.mjson8717416010166628(IABTechLab/trusted-server#1506 and IABTechLab/trusted-server#1608)10166628cache-restore-seedfailed once on compiler-cache publication and passed on reruncargo fmt --all -- --check,cargo check --workspace --all-targets --features "fastly cloudflare",cargo clippy --workspace --all-targets --all-features -- -D warnings,cargo test --workspace --all-targets3d92ee38f84ffbbb