Skip to content

Reject Fastly logging endpoint names the logger cannot install when the manifest loads #506

Description

@aram356

Summary

Manifest validation accepts a Fastly logging endpoint name that the Fastly logger can never install. The mistake then surfaces on every request instead of when the manifest loads.

Behavior today

  • At 10166628, ManifestLoggingConfig.endpoint is validated only with #[validate(length(min = 1_u64))] (crates/edgezero-core/src/manifest.rs:857-858).
  • A manifest with [adapters.fastly.logging] endpoint = "ts:log" loads, compiles and validates.
  • At request time the managed install fails with managed logging configuration is invalid, and the request goes unanswered (Fastly custom runners send no response when the managed logger fails to install #505).

Acceptance criteria

  • Loading a manifest whose [adapters.fastly.logging] endpoint the Fastly logger would reject fails at load time, with an error that names the field.
  • An app! application gets that error at compile time.
  • A test covers the rejected forms, including a name containing :.

Related

Activity

  1. added theissue type on Nov 15, 2026
  2. added a commit that references this issue on Nov 15, 2026
    4cbabfe
  3. aram356 commented on Nov 15, 2026

    @aram356
    CollaboratorAuthor

    CREATOR: fixed in 4cbabfee on PR #275.

    Shared manifest validation now rejects the effective Fastly endpoint before finalization and during app! expansion: empty, LF, colon, and exact reserved stdout/stderr. Errors name the declared field without echoing its value. Existing case-insensitive lookup, whole-section overrides and unrelated validation errors are preserved; other adapters' endpoint formats are unchanged. The unused reserved scaffold default is removed, while generated apps keep their existing project-specific endpoint. Active guide examples are aligned.

    Committed-head checks (exit 0):

    cargo test --offline --locked -p edgezero-core --lib manifest::tests
    test result: ok. 88 passed; 0 failed; 0 ignored; 0 measured; 1044 filtered out; finished in 0.01s
    
    cargo test --offline --locked -p edgezero-macros --lib
    test result: ok. 120 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
    

    The existing generated-workspace gate also passes with an actual valid app! compile control and an invalid control requiring the field-specific compiler diagnostic. Its pre-fix run failed because the invalid endpoint compiled. The full prescribed local suite and 35 additional format/lint/build/docs checks pass.

    Endpoint provisioning/host availability still belongs to runtime validation. No SDK change or compatibility path was added. The separately disclosed seven-case assembly-attestation blocker remains open; this does not claim the entire PR is merge-ready. The issue remains open until default-branch integration.

  4. self-assigned this
    on Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions