You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reject Fastly logging endpoint names the logger cannot install when the manifest loads #506
Manifest validation accepts a Fastly logging endpoint name that the Fastly logger can never install. The mistake then surfaces on every request instead of when the manifest loads.
Behavior today
At 10166628, ManifestLoggingConfig.endpoint is validated only with #[validate(length(min = 1_u64))] (crates/edgezero-core/src/manifest.rs:857-858).
A manifest with [adapters.fastly.logging] endpoint = "ts:log" loads, compiles and validates.
Shared manifest validation now rejects the effective Fastly endpoint before finalization and during app! expansion: empty, LF, colon, and exact reserved stdout/stderr. Errors name the declared field without echoing its value. Existing case-insensitive lookup, whole-section overrides and unrelated validation errors are preserved; other adapters' endpoint formats are unchanged. The unused reserved scaffold default is removed, while generated apps keep their existing project-specific endpoint. Active guide examples are aligned.
Committed-head checks (exit 0):
cargo test --offline --locked -p edgezero-core --lib manifest::tests
test result: ok. 88 passed; 0 failed; 0 ignored; 0 measured; 1044 filtered out; finished in 0.01s
cargo test --offline --locked -p edgezero-macros --lib
test result: ok. 120 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
The existing generated-workspace gate also passes with an actual valid app! compile control and an invalid control requiring the field-specific compiler diagnostic. Its pre-fix run failed because the invalid endpoint compiled. The full prescribed local suite and 35 additional format/lint/build/docs checks pass.
Endpoint provisioning/host availability still belongs to runtime validation. No SDK change or compatibility path was added. The separately disclosed seven-case assembly-attestation blocker remains open; this does not claim the entire PR is merge-ready. The issue remains open until default-branch integration.
Activity
fix(fastly): validate logging and reject setup failures
aram356 commentedon Nov 15, 2026
CREATOR: fixed in
4cbabfeeon PR #275.Shared manifest validation now rejects the effective Fastly endpoint before finalization and during
app!expansion: empty, LF, colon, and exact reservedstdout/stderr. Errors name the declared field without echoing its value. Existing case-insensitive lookup, whole-section overrides and unrelated validation errors are preserved; other adapters' endpoint formats are unchanged. The unused reserved scaffold default is removed, while generated apps keep their existing project-specific endpoint. Active guide examples are aligned.Committed-head checks (exit 0):
The existing generated-workspace gate also passes with an actual valid
app!compile control and an invalid control requiring the field-specific compiler diagnostic. Its pre-fix run failed because the invalid endpoint compiled. The full prescribed local suite and 35 additional format/lint/build/docs checks pass.Endpoint provisioning/host availability still belongs to runtime validation. No SDK change or compatibility path was added. The separately disclosed seven-case assembly-attestation blocker remains open; this does not claim the entire PR is merge-ready. The issue remains open until default-branch integration.