Skip to content

fix repo panel rendering on top of repo content again - #18

Merged
omarkurt merged 1 commit into
HappyHackingSpace:mainfrom
omarkurt:fix/repo-panel-sidebar-wait
Nov 7, 2026
Merged

omarkurt merged 1 commit into
HappyHackingSpace:mainfrom
omarkurt:fix/repo-panel-sidebar-wait

Conversation

@omarkurt

@omarkurt omarkurt commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Fixes #17 (regression of #4).

  • findRepoSidebar fell back to main, which always exists, so waitFor resolved immediately, before React rendered the About pane. The content fallbacks now live in findRepoContentFallback() and are used only after the wait times out.
  • CodeViewSidebar-module__borderGrid no longer matched (class is now hashed); the selector is now hash-agnostic.

Tested locally: the panel renders at the top of the About sidebar on repo pages.

Summary by CodeRabbit

  • Bug Fixes
    • Improved repository sidebar detection across more GitHub layouts.
    • Added fallback content areas when the sidebar isn’t found.

findRepoSidebar fell back to main, which always exists, so waitFor resolved before React rendered the About pane. Only use content fallbacks after the wait times out, and make the borderGrid selector hash-agnostic.

Fixes HappyHackingSpace#17
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The repository panel lookup now matches hashed CodeViewSidebar class names. If no sidebar matches, repository loading searches fallback content selectors.

Changes

Repository panel target selection

Layer / File(s) Summary
Sidebar matching and fallback lookup
packages/extension/entrypoints/github-panel.content.ts
The sidebar selector matches class names containing CodeViewSidebar-module and borderGrid. findRepoSidebar returns null when no sidebar matches. Repository loading then searches #repo-content-turbo-frame, .repository-content, and main.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: Minimal · up to e05ea

The change delays content fallback selection so the About sidebar has time to render. No merge-blocking regression is established; the existing late-sidebar placement limitation remains a follow-up.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Biome (2.5.15)

packages/extension/entrypoints/github-panel.content.ts

Biome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins.

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the sidebar wall
Hashed class names no longer stall
If no sidebar meets its gaze
It seeks content through fallback ways
Then hops along its panel trail

@omarkurt
omarkurt merged commit 50895f3 into HappyHackingSpace:main Nov 7, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repo panel renders on top of repo content again (regression of #4)

1 participant