Repository navigation
fix: include enabled features in memory code key - #36
Merged
VikramLex merged 1 commit intoNov 13, 2026
Merged
Conversation
Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>
dajiaohuang
marked this pull request as ready for review
November 12, 2026 17:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graphicle-memory exposes build_code() as a key for data derived from the crate. Supported Cargo feature profiles change parser behavior, but the previous key hashed only source files and package version, so no-default and default-feature builds returned the same key.
Include the sorted enabled CARGO_FEATURE_* names in the build hash, with separators. This makes feature-dependent derived data keys distinct while keeping the same key stable for the same source, version, and feature set.
Validation: the locked no-default-features and default-feature library builds both passed. Before the change they emitted the same key; after the change they emitted 59c2eaa000398a61 and fd7d6e8852a6b1fb. cargo fmt --check passed.