Repository navigation
Conversation
Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>
dajiaohuang
marked this pull request as ready for review
November 12, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Python SDK treated a missing MCP
readOnlyHintas read-only. The service treats a tool as a write unless it explicitly declaresreadOnlyHint: true, and extension tool specs can be published without that annotation. As a result,Tools(project)could publish an unmarked write tool to a model despiteinclude_write=False.Change
Only tools with an explicit
readOnlyHint: trueare exposed by default.include_write=Truecontinues to opt into all published tools. The regression test covers explicit read, explicit write, empty annotations, and missing annotations.Validation
py -3 -m pytest -q tests/test_tools.py: 1 passed (pytest plugin auto-loading disabled for this process because a machine-level Home Assistant plugin imports POSIX-onlyfcntlon Windows).git diff --check: passed.