Skip to content

fix: remap duplicate graph edges to final node - #29

Merged
VikramLex merged 1 commit into
Graphicle-AI:mainfrom
dajiaohuang:w18/graphicle-dedup-transitive-main
Nov 13, 2026
Merged

VikramLex merged 1 commit into
Graphicle-AI:mainfrom
dajiaohuang:w18/graphicle-dedup-transitive-main

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • Keep node alias remaps pointed at the final canonical ID when repeated duplicate labels successively select shorter IDs.
  • Add a regression test for edges that previously remained attached to a removed intermediate node ID.

Validation

  • cargo test --lib edge_aliases_follow_repeatedly_replaced_canonical_id — passed on current main base e4437fc3c9769a5f8983e811b04b84b3c9288d66.
  • rustfmt --edition 2024 --check crates/graphicle-graph/src/build_normalize.rs — passed.
  • git diff --check origin/main...HEAD — passed.

Signed-off-by: dajiaohuang <mikewushuwen@outlook.com>
@VikramLex
VikramLex merged commit eda9387 into Graphicle-AI:main Nov 13, 2026
11 checks passed
VikramLex added a commit that referenced this pull request Nov 13, 2026
…te divergence from Graphify 0.9.103

Signed-off-by: VikramLex <vikramlex@karlexai.com>
VikramLex added a commit that referenced this pull request Nov 13, 2026
The per-replacement scan of every alias (#29) costs replacements times duplicates, which a monorepo with many same-label nodes can make large. Each alias now follows its chain once at the end, with a hop bound that also ends on a node listed twice under one id.

Signed-off-by: VikramLex <vikramlex@karlexai.com>
VikramLex added a commit that referenced this pull request Nov 13, 2026
Signed-off-by: VikramLex <vikramlex@karlexai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants