Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,26 @@ jobs:
if: needs.detect.outputs.pending == 'false'
runs-on: ubuntu-latest
timeout-minutes: 5
# The org no longer lets GITHUB_TOKEN create pull requests, so release-please opens the
# Release PR as getstream-sdk-bot. Its key lives only in the sdk-bot environment, which
# deploys from the default branch only. On a hotfix branch the job runs without the key on
# a read-only GITHUB_TOKEN: a push with nothing to release stays green, one with changes
# fails until the sdk-bot environment allows that branch.
environment: ${{ github.ref_name == github.event.repository.default_branch && 'sdk-bot' || '' }}
permissions:
contents: write
issues: write
pull-requests: write
contents: read
steps:
- id: app
if: github.ref_name == github.event.repository.default_branch
uses: actions/create-github-app-token@f418cff399f7aef4c2f0ad47e25ca7a6abbdd6fc # v3.4.0
with:
client-id: Iv23lioh9qYGjBIp9nsK
private-key: ${{ secrets.SDK_BOT_PRIVATE_KEY }}
permission-contents: write
permission-pull-requests: write
- uses: googleapis/release-please-action@5c625bfb5d1ff62eadeeb3772007f7f66fdcf071 # v4.4.1
with:
token: ${{ steps.app.outputs.token || github.token }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release PR CI skip never fires

Medium Severity

Release PRs now come from getstream-sdk-bot[bot], but release-only in ci.yml still matches only github-actions[bot]. That job never runs, so the unit lane no longer skips and 🧪 Tests waits on the full suite for every version bump.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ae49519. Configure here.

config-file: release-please-config.json
manifest-file: .release-please-manifest.json
target-branch: ${{ github.ref_name }}
Expand Down