Repository navigation
Conversation
…bump test sends (#2907) leader_among now names a leader only once the same broker still leads two seconds later, so the group-start leader is not picked. send_ok retries retriable errors and the first send's result is asserted. Spec-Unaffected: test only.
el-bri-ga
enabled auto-merge (squash)
November 21, 2026 16:54
|
Performance comparison (fast subset)❔ 3 large change(s) in the worse direction these trials can neither confirm nor rule outWelch's t-test, p < 0.05, minimum practical effect 3.0%. A worse change of 10.0% or more that is not significant is inconclusive: rerun the cell with more trials before trusting it. Baseline and candidate trials alternated on the same runner instance in this job, with the side that goes first flipping each round, to control for ambient noise. This check is advisory only and does not block merging.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #2907
leader_among in the failures suite could name the group-start leader before the transfer to placement's leader. It now requires the same single broker to lead on two reads 2 s apart, within a bounded wait. send_ok retries retriable errors, and the first send's result is asserted. Test only.