Skip to content

An unclear triage answer frees the agent that holds the item - #493

Merged
el-bri-ga merged 2 commits into
mainfrom
fix/issue-488
Nov 20, 2026
Merged

el-bri-ga merged 2 commits into
mainfrom
fix/issue-488

Conversation

@el-bri-ga

Copy link
Copy Markdown
Contributor

Fixes #488.

A person can accept a root before its triage item finishes, and an agent can claim the fix. A later triaged with unclear then set open_question on the held root, so it was held and waiting on a person at once. From format 27 the fold ends the holder's hold when the answer opens the question, as work_ask does: the claim is given back and the item waits in Needs you. The holder's next write is refused as not_holder; its claim extension notices the hold is gone (the tracker already checks the log for that). Below 27 nothing changes, so no old log folds differently.

Tests: fold unit tests (frees at 27, unchanged at 26, nothing to free), a format 27 log pinned in wasm/golden, and the fault sweep now accepts roots before triage ends, which reproduces the issue (seed 74 failed with 'p1 is held with an open question' with the gate removed, passes with it; 200 seeds green locally). Docs: upgrades table, work tracker, fault sweep. No Upgrade-Break: no new record, and a fresh log starts below 27.

Review notes

  • Decided: end the hold rather than refuse the unclear answer, since the work tracker already says an unclear item reaches a person as a question even after an accept; refusing would leave triage unable to say so.
  • Decided: gated by a new format (27) per the fold rules, even though no record or field is new, because an unraised build would fold the same log differently.
  • Decided: the hold ends without a charge or a new tracker write; the claim given back matches a question's.
  • Dashboard: no UI change.

@el-bri-ga
el-bri-ga enabled auto-merge (squash) November 20, 2026 06:36
@sonarqubecloud

Copy link
Copy Markdown

@el-bri-ga
el-bri-ga merged commit 229983f into main Nov 20, 2026
10 checks passed
@el-bri-ga
el-bri-ga deleted the fix/issue-488 branch November 20, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A person's early accept lets a later unclear triage open a question on a held root

1 participant