Skip to content

supervise_status: surface a worker's last log line when it exits quickly - #491

Merged
el-bri-ga merged 1 commit into
mainfrom
fix/issue-480
Nov 20, 2026
Merged

el-bri-ga merged 1 commit into
mainfrom
fix/issue-480

Conversation

@el-bri-ga

Copy link
Copy Markdown
Contributor

Fixes #480.

A command worker that fails or ends within min_run_seconds now carries last_log_line in supervise_status (finished / failed): the last non-blank line of its out.log, read from the final 4 KiB, control characters dropped, at most 300 characters.

Tests: a_worker_that_fails_fast_reports_the_last_line_of_its_log fails without the fix (field is null) and passes with it; a unit test covers blank lines, control characters, length and an empty log. Docs: README, docs/design/supervise.md, threat model row and citation.

Review notes

  • Decided: only failed or quick ends carry the line; a worker that runs long and exits 0 does not, so the status stays small.
  • Decided: the line is worker-controlled text; the threat-model row says it is data, bounded and stripped of control characters. No new field on the wire or log format; nothing recorded in the tracker.

@el-bri-ga
el-bri-ga enabled auto-merge (squash) November 20, 2026 05:48
@sonarqubecloud

Copy link
Copy Markdown

@el-bri-ga
el-bri-ga merged commit 55f88c2 into main Nov 20, 2026
10 checks passed
@el-bri-ga
el-bri-ga deleted the fix/issue-480 branch November 20, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

supervise_status: surface a worker's last log line when it exits quickly

1 participant