Repository navigation
Triage acceptance policy; admitted roots wait for triage - #483
Merged
Merged
Conversation
…er answers and person-touched roots, take-back restores the tier and resume items
el-bri-ga
enabled auto-merge (squash)
November 20, 2026 01:40
Upgrade-Break: a new log starts at format 25, which a build that reads up to 24 refuses, so the previous build cannot read a log this build created.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #476, closes #481
A configured triage policy lets the tracker accept routine triage itself, and admit mode now leaves a root in Triage until its triage is accepted. No model calls anywhere.
What it does
KBL_TRIAGE_POLICY_FILE:{"rules":[{"name","tiers","areas","deny_areas","types","sizes","deny_needs"}]}. Each rule needs a name and at least one condition; the first match names the acceptance. No file: every triage waits for a person.acceptedas itself withadmitted_by: <rule>(format 25). It runs when the triage item is completed and in the sweep, so a crash in between is finished by the next sweep; a second write is refused by the fold.POST /v1/work/proposals/undo-admission(undo_admissiontool, "Take back the policy acceptance" in the panel): the root returns to Triage with triage's answer and the policy stays off it. A person's own accept clears the rule's name.accepted, sowork_nextandwork_peekhand out triage and augment first. From format 25, finishing a fix cancels triage and augment children nobody holds and that have no recorded work; any other open child still refuses, and the refusal now names it and its holder.Design calls
tiersis a list (like the fit rows), not amax_tier, because tier 0 is the most urgent and "at most N" reads both ways.policy_blocker), so a rule can only narrow it.policy_held: the policy never accepts them again.admitted_byfrom anyone but the tracker, plus the ingest route refusing it, keeps the record the tracker's own.accepted). The accept takes triage's tier. Skip rules keep theirs.Tests (each revert-checked): fold tests for the policy, take-back, and moot children; format 25 corpus (core, wasm golden); tracker tests (match, no-match, crash recovery, person wins, below format, ingest refusal); the tracker fault sweep now runs policy roots under crashes (default seeds now 100); policy file parser tests; dashboard unit tests;
dev/check-tracker-policy.mjsin CI. Ingest tests that expected an accepted root changed because admit no longer accepts.