Repository navigation
Fix systemd stdin setting for exe.dev job launches - #402
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exe.dev job launches failed before the harness started because the transient service used
StandardInput=/dev/null, which systemd rejects. UseStandardInput=null; the launcher still reads its JSON payload through the existing shell input redirection.Add a regression test that validates generated standard I/O settings with systemd's parser and rejects parser warnings. The test fails with the old setting and passes with the fix.
Validation: all 35 execution-backend tests pass; a real local transient systemd service starts and reads the redirected payload; full root
npm testpasses on Node 24.12.0/npm 11.19.0 with isolated PostgreSQL; GitHub CI passes. The first local full run hit an unrelated 40ms proxy reconnect timing assertion; that file and the complete unchanged suite passed on rerun.Incident: https://app.factorize.sh/job-runs/e291b11e-007b-4dc3-9ced-d3e7f026502e