Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/app/src/features/runs/continuous-trace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export function ContinuousTrace({ runId, revision, active, onReset, preview = fa
const latestSequence = items.at(-1)?.sequence ?? 0;
const live = useQuery({
queryKey: ["runs", runId, "conversation-tail", revision],
enabled: !preview && active && visible && !!trace.data,
enabled: active && visible && !!trace.data,
queryFn: async ({ signal }) => {
const { data, error, response } = await api.GET("/api/v1/runs/{runId}/trace-pages", { signal, params: { path: { runId }, query: { after: latestSequence, revision, limit: 100 } } });
if (!data || error) throw response.status === 404 ? new RunNotFoundError() : new Error(messageOf(error)); return data;
Expand Down Expand Up @@ -182,6 +182,7 @@ export function ContinuousTrace({ runId, revision, active, onReset, preview = fa
{trace.error && <p role="alert">{trace.error.message}</p>}{trace.isPending && <p role="status">Loading conversation…</p>}
{!trace.isPending && !grouped.length && <p className="text-sm text-slate-600 dark:text-slate-400">No assistant messages yet.</p>}
{grouped.map(item => item.kind === "assistant" ? <article key={item.event.id} className="min-w-0"><EventBody event={item.event} /></article> : <Disclosure key={groupKey(item)} className={traceClasses("tool_call")} open={expanded.has(groupKey(item))} onToggle={event => { const key = groupKey(item); const open = event.currentTarget.open; setExpanded(previous => { const next = new Set(previous); open ? next.add(key) : next.delete(key); return next; }); }}><Summary>{item.count} Tool Call{item.count === 1 ? "" : "s"}</Summary>{expanded.has(groupKey(item)) && <div className="space-y-3">{item.events.map(event => <div key={event.id}><EventBody event={event} /></div>)}</div>}</Disclosure>)}
{active && <p data-run-trace-live role="status" aria-label="Run is still running" className="mt-5 flex items-center gap-2 text-sm font-medium"><RunStatusLabel state="running" /><span className="trace-live-dots" aria-hidden="true"><span /><span /><span /></span></p>}
</div>;
const virtualItems = virtualizer.getVirtualItems();
return <>{trace.error && <p role="alert">{trace.error.message}</p>}{trace.isPending && <p role="status">Loading conversation…</p>}
Expand Down
25 changes: 25 additions & 0 deletions packages/app/test/runs.browser.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,31 @@ test("running trace shows animated dots and polls forward from its latest event"
assert.deepEqual(tailRequests.slice(0, 2), [1, 2], "each poll should request events after the latest displayed sequence");
await context.close();
});
test("active job run preview refreshes recent activity without scrolling and shows Running at the bottom", async () => {
const { context, page } = await setup(); const tailRequests = [];
const event = sequence => ({ id: `preview-${sequence}`, sequence, type: "assistant_message", title: `Preview ${sequence}`, preview: `Preview ${sequence}`, display: {} });
await page.route(`**/api/v1/runs/${runId}/status`, route => route.fulfill({ json: { id: runId, job_id: jobId, job_name: "Job", run_name: "Live preview", state: "running", finalizing: false, trace_revision: "preview", artifact_state: "pending", created_at: time, updated_at: time, started_at: time, destination_url: null } }));
await page.route(`**/api/v1/runs/${runId}/trace-pages?**`, route => {
const query = new URL(route.request().url()).searchParams;
if (query.has("after")) {
const after = Number(query.get("after")); tailRequests.push(after);
return route.fulfill({ json: { items: [event(after + 1)], nextCursor: null, previousCursor: null, revision: "preview", reset: false } });
}
return route.fulfill({ json: { items: [event(1)], nextCursor: null, previousCursor: null, revision: "preview", reset: false } });
});
await page.goto(origin + "/job-runs/" + runId);
const trace = page.locator("[data-run-trace-preview]");
const indicator = trace.locator("[data-run-trace-live]");
await indicator.waitFor();
assert.equal(await indicator.locator(".trace-live-dots > span").count(), 3);
assert.equal(await trace.locator("[data-run-trace-scroll]").count(), 0, "recent activity should not use the scrolling history trace");
await page.evaluate(() => { document.scrollingElement.scrollTop = 0; });
await page.getByText("Preview 3", { exact: true }).waitFor({ timeout: 7000 });
assert.deepEqual(tailRequests.slice(0, 2), [1, 2], "preview polling should continue after the latest displayed sequence");
assert.ok(await trace.getByText("Preview 3", { exact: true }).count());
assert.equal(await page.evaluate(() => document.scrollingElement.scrollTop), 0, "new activity should not auto-scroll the page through older entries");
await context.close();
});
test("full run trace uses pull-to-load history, preserves the anchor, and never crashes on disclosure toggles", async () => {
const { context, page } = await setup(); const requests = [];
const event = (sequence, type = "assistant_message") => ({ id: `trace-${sequence}`, sequence, type, title: `Trace ${sequence}`, preview: `Trace ${sequence}`, display: {} });
Expand Down
Loading