[Scra3]

Part of PRD-29 (QA bug 16)

Bug: in Full AI, a Trigger Action step saved without approval branches whose action now requires approval errored as a configuration error, but agent-client had already filed an approval request that stayed open with no run. Approving it ran the action outside the workflow.

Fix: on such a step the executor runs the action with a new agent-client option, skipApprovalRequest, so the agent's refusal comes back as ActionRequiresApprovalError and the step errors with ApprovalBranchesMissingError and no open request. The message no longer names a request. agent-client's default is unchanged: it still files the request for every other caller.

Tests

• agent-client: skipApprovalRequest throws ActionRequiresApprovalError without calling the request creator; the existing tests still cover the default filing.
• Adapter: the flag is forwarded to execute.
• Executor: a step that refuses approvals (formless and with a form) errors with the configuration error, files no request and names none; a validation rejection still hands the form back; a step with branches, or with approvalOutcomes absent, sends no flag and still files and links its request.

Refactor: the step's approval handling moved out of trigger-record-action-step-executor.ts into trigger-action-approvals.ts (TriggerActionApprovals), in its own commit with no behaviour change.

Out of scope: Manual and AI-assisted. There the front's native form files the request, so a step without branches still ends with an open request named in the error.

🤖 Generated with Claude Code

Note

Skip approval request when a trigger-action step has no approval branches

• Adds skipApprovalRequest to ExecuteActionQuery and ActionExecuteOptions, and forwards it from agent-client-agent-port.ts to Action.execute
• TriggerRecordActionStepExecutor.executeOnExecutor sets the flag for steps saved without approval branches. If the action still requires approval, it deletes the saved executing record and throws ApprovalBranchesMissingError
• Extracts approval-outcome logic from the executor into a new TriggerActionApprovals helper in trigger-action-approvals.ts
• Behavioral Change: steps without approval branches no longer file approval requests; a required approval now results in a configuration error and executing-record cleanup instead of a pause

^{Macroscope summarized 9a3f9d2.}

[linear-code]

PRD-29

[Scra3]

Spec (PRD-29): conforms to QA bug 16, a Full AI step saved without branches errors as configuration and files no request.

PRD-29 has 13 unvalidated decisions: not final.

[qltysh]

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on feature/prd-29-handle-action-approvals-within-workflows by 0.1%.

Modified Files with Diff Coverage (4)

Rating	File	% Diff	Uncovered Line #s
	...-executor/src/executors/trigger-record-action-step-executor.ts	100.0%
	packages/agent-client/src/domains/action.ts	100.0%
	...ages/workflow-executor/src/adapters/agent-client-agent-port.ts	100.0%
	...es/workflow-executor/src/executors/trigger-action-approvals.ts	100.0%
	Total	100.0%

Commit 9a3f9d2 · 🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[Scra3]

Forest Validator · Review: findings posted

When (UTC)	Commit	Step	Result
09/11 20:38	0303b1b	Review	findings posted · run 2074-20261109203327-Scra3

1 earlier step

When (UTC)	Commit	Step	Result
09/11 20:15	935b21a	Review	findings posted · run 2074-20261109200927-Scra3

[qltysh]

2 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many returns (count = 4): checkIdempotency	1
qlty	Structure	Function with high complexity (count = 12): checkIdempotency	1

[Scra3]

Spec (PRD-29): conforms to QA bug 16, a Full AI step saved without branches errors as configuration and files no request.

PRD-29 has 14 unvalidated decisions: not final.