feat: Retry event delivery and close the client with a timeout by flagsmithsmith[bot] · Pull Request #253 · Flagsmith/flagsmith-java-client

flagsmithsmith · 2026-11-11T15:37:14Z

Contributes to Flagsmith/sdk-spec#13
Contributes to Flagsmith/sdk-spec#23

Its entry in Flagsmith/sdk-spec's compatibility matrix at v0.9.0: `core events local-evaluation`.

Spec v0.7.1 runs the `@events` scenarios for this SDK: getting an experiment flag, tracking an event and tracking an exposure event, all with events enabled. The SDK already implements these (#226), so the steps file wires each step to FlagsmithClient.getExperimentFlag, trackEvent and trackExposureEvent, and creates the events-enabled client through FlagsmithConfig, next to the local evaluation client. (cherry picked from commit 0c48af8) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 29cbe7b) (cherry picked from commit 723a712)

Spec v0.8.0 specifies how SDKs deliver events. The event processor now: - Times out each events request after 3 s, and gives a batch 3 attempts, backing off from 1 s, doubling, with full jitter. Network errors, timeouts, 408, 429, 500, 502, 503 and 504 are retried. - Keeps a batch whose last attempt failed transiently in the buffer, ahead of newer events, for the next flush, unless that attempt got a 500. Any other error response drops the batch. - Stops event tracking, dropping the buffer, on a 401 or 403. - Sends one batch at a time, and caps the buffer at 1000 events by dropping the oldest, kept events included. - Never fails `flushEvents()`, which waits for the send, retries included. `FlagsmithClient.close(timeout, unit)` sends the buffered events for at most the timeout, then abandons the request in flight. `close()` waits for one batch's worst case, 12 s. The spec steps file wires the new steps: flushing events, closing with a timeout, tracking a range of events, and a client with both local evaluation and events enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 88fa258)

coderabbitai · 2026-11-11T15:37:20Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 67fab327-ab5e-44bf-995a-58860ed2aae0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

codspeed · 2026-11-11T15:49:46Z

Merging this PR will not alter performance

✅ 15 untouched benchmarks

_{Comparing openhands/sdk-spec-v0.9.0 (abdd2fd) with main (1c633a1)}

Zaimwa9

Requesting changes. Spec passes and the structure is good, but events behind a kept batch are never sent on flush or close, and a full buffer after a kept batch retries on every track. Please also retitle: the tracking methods are already on main.

…hile A flush requested while a batch was in flight completed without sending the events tracked since, when that batch was kept, and close() then dropped them without trying. Such a flush now sends the whole buffer, the kept batch first, and so does close(). After a kept batch, a full buffer no longer starts a new retry cycle on every tracked event: it waits for the next timer tick or explicit flush. A batch that gets through lifts the hold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

flagsmithsmith · 2026-11-12T16:33:05Z

Thanks @Zaimwa9. Addressed in f3c57d7.

events behind a kept batch are never sent on flush or close

Fixed. A flush waiting behind a kept batch now sends the whole buffer, kept batch first. close() does the same within its timeout. Details in the inline reply.

a full buffer after a kept batch retries on every track

Fixed. After a kept batch, a full buffer waits for the next timer tick or explicit flush. The next batch that gets through lifts the hold. Details in the inline reply.

Please also retitle: the tracking methods are already on main.

Retitled to "feat: Retry event delivery and close the client with a timeout".

Locally, mvn clean install passes (539 tests, with the engine-test-data submodule checked out). So do the release build and the spec at v0.9.0 with core events local-evaluation (24/24).

Zaimwa9

Requesting changes. Both earlier points are fixed, but with the flush timer disabled (withEventsFlushIntervalMillis(0)) one kept batch stops size-triggered delivery for the rest of the process.

With `withEventsFlushIntervalMillis(0)` no tick ever lifts the hold a kept batch puts on size-triggered flushes, so one kept batch stopped them for the rest of the process. Without a timer, the hold now expires 10 s (the default flush interval) after the batch was kept; the next full buffer then sends it. With a timer, the next tick still lifts it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

flagsmithsmith · 2026-11-13T14:35:38Z

Thanks @Zaimwa9. Addressed in abdd2fd.

with the flush timer disabled (withEventsFlushIntervalMillis(0)) one kept batch stops size-triggered delivery for the rest of the process.

Fixed. With the timer off, the hold now expires 10 s after the batch was kept (the default flush interval), and the next full buffer sends the kept batch and the newer events. With a timer, the next tick still lifts the hold. There are two new tests; details are in the inline reply.

Locally, mvn clean install (541 tests, EngineTest included) and the release build both pass.

🤖 I have created a release *beep* *boop* --- ## [8.5.0](v8.4.0...v8.5.0) (2026-11-13) ### Features * Retry event delivery and close the client with a timeout ([#253](#253)) ([63ccae9](63ccae9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).  --- ## Summary by cubic Releases version 8.5.0, updating the changelog and project version. The new version adds retry logic for event delivery and closes the client with a timeout. <sup>Written for commit bc19dc2. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/Flagsmith/flagsmith-java-client/pull/254?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="View guided diff" src="https://www.cubic.dev/buttons/review-in-cubic-light.svg"></picture></a> <a href="https://www.cubic.dev/action/auto-fix/pr/Flagsmith/flagsmith-java-client/254?returnTo=https%3A%2F%2Fgithub.com%2FFlagsmith%2Fflagsmith-java-client%2Fpull%2F254&source=description" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/turn-on-auto-fix-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"><img alt="Turn on auto-fix" src="https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"></picture></a>

renovate Bot and others added 4 commits November 11, 2026 15:33

deps: update dependency flagsmith/sdk-spec to v0.9.0

4b7b0d7

ci: Run the SDK spec for this SDK's capabilities

ce5ec45

Its entry in Flagsmith/sdk-spec's compatibility matrix at v0.9.0: `core events local-evaluation`.

flagsmithsmith Bot added the sdk-spec Bumps of the Flagsmith SDK behavioural spec label Nov 11, 2026

flagsmithsmith Bot mentioned this pull request Nov 11, 2026

feat: Support getExperimentFlag, trackEvent and trackExposure methods #252

Closed

This was referenced Nov 11, 2026

Retry event delivery and flush on close Flagsmith/sdk-spec#23

Open

Support getExperimentFlag, trackEvent and trackExposure methods Flagsmith/sdk-spec#13

Closed

flagsmithsmith Bot marked this pull request as ready for review November 11, 2026 15:51

flagsmithsmith Bot requested a review from a team as a code owner November 11, 2026 15:51

flagsmithsmith Bot requested review from emyller and removed request for a team November 11, 2026 15:51

flagsmith-engineering Bot assigned emyller Nov 11, 2026

Zaimwa9 requested changes Nov 12, 2026

View reviewed changes

Comment thread src/main/java/com/flagsmith/threads/EventProcessor.java Resolved

Comment thread src/main/java/com/flagsmith/threads/EventProcessor.java Resolved

flagsmithsmith Bot changed the title ~~feat: Support getExperimentFlag, trackEvent and trackExposure methods~~ feat: Retry event delivery and close the client with a timeout Nov 12, 2026

flagsmithsmith Bot requested a review from Zaimwa9 November 12, 2026 16:50

flagsmith-engineering Bot assigned Zaimwa9 Nov 12, 2026

Zaimwa9 requested changes Nov 13, 2026

View reviewed changes

Comment thread src/main/java/com/flagsmith/threads/EventProcessor.java Resolved

flagsmithsmith Bot requested a review from Zaimwa9 November 13, 2026 14:51

Zaimwa9 approved these changes Nov 13, 2026

View reviewed changes

flagsmithsmith Bot requested a review from Zaimwa9 November 13, 2026 14:58

Zaimwa9 merged commit 63ccae9 into main Nov 13, 2026
17 checks passed

Zaimwa9 deleted the openhands/sdk-spec-v0.9.0 branch November 13, 2026 14:59

flagsmithdev mentioned this pull request Nov 13, 2026

chore(main): release 8.5.0 #254

Merged

Navigation Menu

Repository navigation

feat: Retry event delivery and close the client with a timeout - #253

feat: Retry event delivery and close the client with a timeout#253
Zaimwa9 merged 6 commits into
mainfrom
openhands/sdk-spec-v0.9.0

flagsmithsmith Bot commented Nov 11, 2026

Uh oh!

coderabbitai Bot commented Nov 11, 2026 •

edited

Loading

Review skipped

Uh oh!

codspeed Bot commented Nov 11, 2026 •

edited

Loading

Uh oh!

Zaimwa9 left a comment

Uh oh!

Uh oh!

Uh oh!

flagsmithsmith Bot commented Nov 12, 2026

Uh oh!

Zaimwa9 left a comment

Uh oh!

Uh oh!

flagsmithsmith Bot commented Nov 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

flagsmithsmith Bot commented Nov 11, 2026

Uh oh!

coderabbitai Bot commented Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codspeed Bot commented Nov 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

Zaimwa9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

flagsmithsmith Bot commented Nov 12, 2026

Uh oh!

Zaimwa9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flagsmithsmith Bot commented Nov 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Nov 11, 2026 •

edited

Loading

codspeed Bot commented Nov 11, 2026 •

edited

Loading