Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoder-only fine-tuning checkpoints omit the Sentence Transformers pipeline configuration. Loading a CLS-pooled BGE-M3 checkpoint through
SentenceTransformertherefore creates a mean-pooling pipeline and changes the resulting embeddings.Save the dense pipeline metadata from the base encoder and M3 model save paths, including the configured pooling and optional normalization. The helper writes configuration alongside the existing weights, maps
last_tokento Sentence Transformers'lasttoken, and refreshes the module list on subsequent saves. M3 sparse and ColBERT weights retain their existing save path.Fixes #1326.
Validation
Offline tests use tiny BERT and XLM-RoBERTa models, perform an optimizer step, save through the real trainer, reload with Sentence Transformers, and compare the actual embeddings. They cover all three pooling methods, normalization on/off, repeated saves, and M3 auxiliary weights.
Commands:
The broader legacy-version run also reproduces two existing Trainer compatibility test failures: those tests directly assert the newer
processing_classattribute. Both fail identically with the original production files under Transformers 4.44.2.