Repository navigation
fix: require explicit opt-in for embedder remote code - #1620
Open
original4422 wants to merge 1 commit into
Open
original4422 wants to merge 1 commit into
original4422 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require explicit opt-in for custom code in
FlagAutoModel.from_finetuned, including Hub namespaces, local paths, and checkpoint-parent aliases that match a registry basename. Warn when a recognized model is configured for custom code, and document the compatibility change. Explicit True/False and model-class, pooling, and query-format selection are preserved.Fixes #1579.
Evidence
git diff --checkpass. Reused the original declared editable-install dependencies with Python 3.13.14, Torch 2.15.0, and Transformers 5.22.1.Merge Danger
Door: two-way
Models requiring custom code now need
trust_remote_code=Trueexplicitly, after reviewing that code. This is an intentional compatibility change.Blast Radius: embedder-loading
Prepared with AI assistance.