Skip to content

test(stepcode): wait for the ledger thread before shutting the host down - #88

Merged
forrestlinfeng merged 1 commit into
mainfrom
fix/step-ledger-before-shutdown
Nov 16, 2026
Merged

forrestlinfeng merged 1 commit into
mainfrom
fix/step-ledger-before-shutdown

Conversation

@forrestlinfeng

Copy link
Copy Markdown
Contributor

Follow-up to #87. The Step fixture test still timed out on CI (timed out waiting for the local ledger records both Recipe steps, maintainer/pr-84 runs on 7ad00a1 and 3216641): it polled the ledger after host.shutdown(), but shutdown stops the resident ledger thread (lib/runtime/ledger-thread.js), and a record still in flight is dropped there — the outbox retries it next session. So on a slow runner the poll could never succeed. The test now waits for both records while the host is still up, then shuts down. Test-only.

🤖 Generated with Claude Code

#87 polled the ledger after host.shutdown(), but shutdown stops the resident ledger thread and a record still in flight is dropped (the outbox retries it next session), so on a slow runner the poll could never succeed ('timed out waiting for the local ledger records both Recipe steps' on maintainer/pr-84). Wait for both records while the host is still up.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现需要报告的问题。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=88、head_sha="6d023c6f0e896a323debbb0fe598463082b4bb49",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 6d023c6f0e89

@forrestlinfeng
forrestlinfeng merged commit e36d730 into main Nov 16, 2026
13 checks passed
@forrestlinfeng
forrestlinfeng deleted the fix/step-ledger-before-shutdown branch November 16, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant