Repository navigation
test(stepcode): wait for the ledger thread before shutting the host down - #88
Merged
Merged
Conversation
#87 polled the ledger after host.shutdown(), but shutdown stops the resident ledger thread and a record still in flight is dropped (the outbox retries it next session), so on a slow runner the poll could never succeed ('timed out waiting for the local ledger records both Recipe steps' on maintainer/pr-84). Wait for both records while the host is still up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sentinel 已审核此变更,未发现需要报告的问题。 开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 6d023c6f0e89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #87. The Step fixture test still timed out on CI (
timed out waiting for the local ledger records both Recipe steps, maintainer/pr-84 runs on 7ad00a1 and 3216641): it polled the ledger afterhost.shutdown(), but shutdown stops the resident ledger thread (lib/runtime/ledger-thread.js), and a record still in flight is dropped there — the outbox retries it next session. So on a slow runner the poll could never succeed. The test now waits for both records while the host is still up, then shuts down. Test-only.🤖 Generated with Claude Code