Skip to content

fix(stepcode): recover confirmed candidates after a transient write failure (#84 on reviewed #83) - #86

Merged
forrestlinfeng merged 7 commits into
mainfrom
maintainer/pr-84
Nov 16, 2026
Merged

forrestlinfeng merged 7 commits into
mainfrom
maintainer/pr-84

Conversation

@forrestlinfeng

Copy link
Copy Markdown
Contributor

Lands #84 (Step Code: recover confirmed candidates after a transient write failure, by imxyanua) on top of the reviewed #83, because maintainers can't push to #84. #84's own two commits are cherry-picked unchanged (7da1ba7, 24dce2e); merging this supersedes #84.

Reviewed: the Step retry is bounded at 3 attempts, reports through the existing onError, and never retries corrupt-state errors (EINVALIDSTATE). reportedEarlier in lib/app/turn-end.js can only be true when a native turn is retried, so other hosts are unaffected. All 8 new tests fail with plugin.mjs and turn-end.js reverted.

Maintainer commit: 434141b names the delivery condition of a recovered native turn and puts the Step notice in a named constant.

Full suite on this branch (macOS, Node 26): 1172 pass, 0 fail, 6 skipped.

Merge after #83.

🤖 Generated with Claude Code

imxyanua and others added 4 commits November 16, 2026 23:39
Parenthesized arrow parameter, a named delivery condition and a named Step notice, within 120 columns; no
behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。

另有 3 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。

审核覆盖提示: 6 个 hunk/条目缺少完整输入;它们不作为 bug 报告。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=86、head_sha="c411803ee63193dc88ad009c470b5212bccef118",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 c411803ee631

@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 保留了 3 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
开发 agent:请 review 以下 advisory,并逐条给出“已验证无风险 / 已修复 / 转为后续事项”的结论;不要只做整体确认。

  • [P3] 存储生产者与消费者测试未在同一作用域内联合验证 — 存储实现位于 release_integrity_01,对应 test/runtime/file-stores.test.js 位于 release_integrity_03;��...(truncated) · lib/runtime/store/file-stores.js · advisory_e809adfa4ac06ee088b0e4ce
  • [P3] 服务编排路由没有覆盖任何实现文件 — scoped_route_contexts.service_orchestration 被路由到仅包含已跳过 README.md 的 api_contract_01。生命�...(truncated) · lib/app/turn-end.js · advisory_3a61bf946fd5af17e69eb991
  • [P3] 被跳过的发布产物仍被标记为切片审查成功 — size_report.skipped_files 明确包含 plugin.mjs 和 README.md,但多个成功切片又将它们列入 files�...(truncated) · hosts/stepcode/dist/plugin.mjs · advisory_24283bd2e15c931c7040a351

需要完整证据时,可用行末 finding_key 查询 Sentinel PR review context。

由 Sentinel 审核 · 目标提交 c411803ee631

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 正在审核此变更,尚未形成最终结论。

Sentinel 审核中

  • 当前 PR 已进入 reviewer;这是进行中状态,不是绿色通过,也不是红色阻塞。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=86、head_sha="7ad00a1ae8a12a53c43fe2a1d9c4729a80235d88",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 7ad00a1ae8a1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现需要报告的问题。

GitHub CI 未通过。 此状态来自当前 CI gate,不是 Sentinel finding;请以最新 CI attempt 的日志为准。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=86、head_sha="3216641d2db922e6342acaa1a199e7e612528fba",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 3216641d2db9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现需要报告的问题。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=86、head_sha="77ad09e1bf938136fd9d2a51d7cb51bb8fdb162d",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 77ad09e1bf93

@forrestlinfeng
forrestlinfeng merged commit db5432a into main Nov 16, 2026
13 checks passed
@forrestlinfeng
forrestlinfeng deleted the maintainer/pr-84 branch November 16, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants