Repository navigation
fix(stepcode): recover confirmed candidates after a transient write failure (#84 on reviewed #83) - #86
Conversation
Parenthesized arrow parameter, a named delivery condition and a named Step notice, within 120 columns; no behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。 另有 3 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示: 开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 c411803ee631 |
|
Sentinel 保留了 3 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时,可用行末 由 Sentinel 审核 · 目标提交 c411803ee631 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sentinel 正在审核此变更,尚未形成最终结论。 Sentinel 审核中
开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 7ad00a1ae8a1 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sentinel 已审核此变更,未发现需要报告的问题。 GitHub CI 未通过。 此状态来自当前 CI gate,不是 Sentinel finding;请以最新 CI attempt 的日志为准。 开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 3216641d2db9 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sentinel 已审核此变更,未发现需要报告的问题。 开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 77ad09e1bf93 |
Lands #84 (Step Code: recover confirmed candidates after a transient write failure, by imxyanua) on top of the reviewed #83, because maintainers can't push to #84. #84's own two commits are cherry-picked unchanged (7da1ba7, 24dce2e); merging this supersedes #84.
Reviewed: the Step retry is bounded at 3 attempts, reports through the existing
onError, and never retries corrupt-state errors (EINVALIDSTATE).reportedEarlierinlib/app/turn-end.jscan only be true when a native turn is retried, so other hosts are unaffected. All 8 new tests fail withplugin.mjsandturn-end.jsreverted.Maintainer commit:
434141bnames the delivery condition of a recovered native turn and puts the Step notice in a named constant.Full suite on this branch (macOS, Node 26): 1172 pass, 0 fail, 6 skipped.
Merge after #83.
🤖 Generated with Claude Code