Repository navigation
feat(units): declare the count base of a per-N rate - #40
Merged
Merged
Conversation
jm-rivera
changed the base branch from
fix/presentation-read-endpoints
to
dev
October 31, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registries/units.jsongains aratekind,{ref, kind: "rate", count_base, counted, evidence}, anddfo_spec_kit.unitsaRatetype. The graph holds no numeric base for a per-N rate: unit nodes carry only names,scalingFactoris a per-import multiplier, andmeasurementDenominatorreadsCount_Person, so a consumer that reads "per 1,000 people" needs this declared as data.The registry adds 59 rate rows: 8
UnitOfMeasure, 8 SDG, and 43 from the UN deployment, each with evidence. Four have nocountednoun. Units with no series at the 27 entities scanned, hourly dosage units, percent units, an area ratio, and base-one units such as per-household are left out.The UN deployment was sampled over 10 entities out of 127 units, so a later unit may need a row.
DevelopmentFinanceObservatory/apis#140 reads this to replace "per capita" on these series. Stacked on spec-kit#39.
Testing: 88 unit rows, 48 vectors, 622 tools tests, and 271 spec-kit tests pass.