Repository navigation
chore(contract): follow spec-kit 4ad7739 and its recaptured served document - #29
Merged
Merged
Conversation
…cument contract/SOURCE moves to spec-kit 4ad7739, whose served document comes from dfo-apis ccb661792. The regenerated wire types gain EnrichmentOptionModel.in_long_layout, the analysis, derived, export, frame and share routes, and the description's source_codes. The error maps gain licence_not_redistributable and provenance_unavailable, both PermissionDeniedError with the action stop, which python/docs/errors.md lists. The re-recorded answers read "deaths rate per 1,000 people" where they read "per capita", matching their unit, so the answer fixture and two label expectations follow. answer-definite-fetch now holds no alternative measure, so the nested-spec strict test builds one from the part's own definition. The Notice coverage map leaves WarningModel's unserved_members, withheld_members and withheld_provenances unread, as it leaves their siblings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contract/SOURCEmoves to spec-kit4ad7739, the commit dfo-apisdevpins. Its served document is captured from dfo-apisccb661792, so the wire types gainEnrichmentOptionModel.in_long_layout, which the website's download dialog needs, along with the analysis, derived, export, frame and share routes and the description'ssource_codes.Changes
python/src/dfo/_generated/wire.pyandtypescript/src/generated/openapi.tsare regenerated from the new document.error_map.pyandactions.tsgainlicence_not_redistributableandprovenance_unavailable, the export route's refusals, with the actionstop.python/docs/errors.mdlists both underPermissionDeniedError, whichtest_errors.pychecks. No SDK call reaches the export route.typescript/test/data/answer-choose-candidate-two-parts.jsonis written again from the recording, and two label expectations inanswer.test.tsfollow.answer-definite-fetchthe answer has no alternative measures, so the nested-spec test instrict.test.tsbuilds one from the part's own definition without itsspec_id.test_wire_coverage.pymapsWarningModel's newunserved_members,withheld_membersandwithheld_provenancesto noNoticeattribute, as it maps their siblings.Testing: Python ruff, format, ty, lint-imports, the three generator checks, pytest (4,237 passed) and the family doctor pass. TypeScript lint, typecheck,
generate:check, tests (2,064 passed) and build pass.check_contract_pin.pypasses against the dfo-apisdevpyproject.