Repository navigation
Review DTEx211 MNIST - #509
Merged
Merged
Conversation
foca13
commented
Aug 3, 2026
foca13
commented
Contributor
- The description in the cell suggesting that it might take hours to train in a single GPU is deprecated. In the newer version of DeepTrack2 the gc.Collect bug that was slowing it down was fixed, so now it only takes a few minutes.
- Added the link to the README
Collaborator
|
Hi, Best, |
edudc
suggested changes
Oct 13, 2026
Contributor
There was a problem hiding this comment.
issue (existing, blocking): This issue doesn't belong to this PR modifications, but I think it's important.
Replace this softmax with torch.nn.Identity. dl.Classifier defaults to CrossEntropyLoss, which expects raw logits (Pytorch docs). Applying softmax first changes the objective.
Contributor
Author
There was a problem hiding this comment.
It's a minor change (in terms of code), I think we can include it in this PR
foca13
force-pushed
the
review-DTEx211
branch
from
October 22, 2026 08:50
8f0c991 to
8a98678
Compare
edudc
approved these changes
Oct 27, 2026
foca13
force-pushed
the
review-DTEx211
branch
from
October 27, 2026 15:14
39bfd43 to
d8ba8cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.