Repository navigation
fix(leads): treat social and link-in-bio URLs as no website - #4
Merged
Merged
Conversation
Many businesses put an Instagram, Facebook or Linktree page in Google's website field. Those leads are the ones without a site of their own, but they were counted as having one. The rule lives in contacts.has_real_website and now backs the Has/No website panel filters, the Website chip, the search option and --require-website, and the "with website" count. The card keeps the link and labels its button "Social". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Many businesses put an Instagram, Facebook or Linktree page in Google's website field. Those leads have no site of their own, but they were counted as having one, so they were missing from the No website filter.
What changes
contacts.has_real_websiteandcontacts.is_social_url, backed by a list of social and link-in-bio hosts. Subdomains and URLs without a scheme match; lookalike domains such asnetflix.comandmyfacebook.comdo not.--require-websiteand the with website count use the new rule too.Behaviour to review
{site}message placeholder still inserts the raw link, including social links.Testing
apply_filtersandsummarize: results as expected.has_real_website: all classified correctly.--selftestpasses offscreen, but its demo data has no social links, so its filter counts do not exercise this case. It only adds two direct checks ofhas_real_website.🤖 Generated with Claude Code