Skip to content

Codex ticket analysis: tell the model to leave reviewedAcceptance empty and name the field on refusal (#389) - #390

Merged
DanielNetzer merged 1 commit into
mainfrom
forgecell/issue-389-9345374c8b841ab82b6d8d54
Nov 6, 2026
Merged

DanielNetzer merged 1 commit into
mainfrom
forgecell/issue-389-9345374c8b841ab82b6d8d54

Conversation

@DanielNetzer

Copy link
Copy Markdown
Owner

Implements issue #389.

Molecule: mol-389-04efa720ecc7d7e991697116
Formula: forgecell-github-issue
Base: 1797a27a5792f7de82d111e69abe91b5641175b4
Delivery: 6ba2c6a2cc8aede57ffb7e5b7c065dd3d95358f7

Awaiting exact-commit CI and human review. Harness-reported checks are not independent CI evidence. No merge, deployment or issue closure is authorized.

@DanielNetzer

Copy link
Copy Markdown
Owner Author

Protocol bump. AdapterProtocolVersion goes from 6 to 7, because the pinned contract digest covers the analysis prompt. Every binding fingerprint changes: saved bindings need a reviewed rebind (init --rebind) after upgrading, and in-flight plans need a fresh intake.

Protected failures. The protected regression run failed 10 tests (27 entries with subtests) by design. All of them are exact-message or protocol-pin assertions in the 7 test files this change edits, and they were accepted with amend --accept-protected-failures.

LOWs (not fixed in this slice):

  • labellingViolation cuts the check ID at 128 bytes, which can split a multibyte character. %q escapes it, so the output is harmless.
  • There's no blank line between labellingViolation and uniqueJSON in plan.go.

@DanielNetzer
DanielNetzer marked this pull request as ready for review November 6, 2026 12:24
@DanielNetzer
DanielNetzer merged commit 2a771de into main Nov 6, 2026
2 checks passed
@DanielNetzer
DanielNetzer deleted the forgecell/issue-389-9345374c8b841ab82b6d8d54 branch November 6, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant