Skip to content

chore: add zizmor (pre-commit) and fix its auditor findings - #9

Merged
aldbr merged 3 commits into
DIRACGrid:masterfrom
fstagni:zizmor-auditor
Nov 16, 2026
Merged

aldbr merged 3 commits into
DIRACGrid:masterfrom
fstagni:zizmor-auditor

Conversation

@fstagni

@fstagni fstagni commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Part of DIRACGrid/.github#5 (add zizmor everywhere as pre-commit), same as DIRACGrid/intercede#43.

  • pre-commit: zizmor hook, same config as DIRACGrid/.github (--no-progress --no-online-audits, python3).
  • .github/workflows/pre-commit.yml: runs pre-commit (so zizmor) on pushes and PRs to master, copied from DIRACGrid/.github with the branch adapted.

The workflow hardening from the first commit is gone: master removed both draft-on-changes-requested workflows in #8, and DIRACGrid/.github no longer has the reusable workflow they called.

zizmor v1.32.0 reports no findings with both the default and the auditor persona.

@fstagni
fstagni marked this pull request as ready for review November 15, 2026 14:17
Master dropped the draft-on-changes-requested workflows (DIRACGrid#8), so only the
pre-commit part of this change remains. Align it with DIRACGrid/.github:

- keep the hook's own --no-progress, which `args` would otherwise replace
  (zizmor#582)
- python3 instead of python3.11, so the hook builds on any Python 3
- add the pre-commit workflow, so zizmor runs on every PR and not only
  where someone installed the hook

Assisted-by: Claude:claude-opus-5-5
@aldbr
aldbr merged commit 3344466 into DIRACGrid:master Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants